2018-05-15 20:39:39

by Philippe Cornu

[permalink] [raw]
Subject: [PATCH] drm/bridge: checkpatch strict minor updates

Minor fixes detected with "scripts/checkpatch.pl --strict"

Signed-off-by: Philippe Cornu <[email protected]>
---
Detected when merging "drm: clarify adjusted_mode documentation for bridges"

include/drm/drm_bridge.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index 9917651a7fdd..70131ab57e8f 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -97,7 +97,7 @@ struct drm_bridge_funcs {
/**
* @mode_fixup:
*
- * This callback is used to validate and adjust a mode. The paramater
+ * This callback is used to validate and adjust a mode. The parameter
* mode is the display mode that should be fed to the next element in
* the display chain, either the final &drm_connector or the next
* &drm_bridge. The parameter adjusted_mode is the input mode the bridge
@@ -301,15 +301,15 @@ int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
struct drm_bridge *previous);

bool drm_bridge_mode_fixup(struct drm_bridge *bridge,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode);
+ const struct drm_display_mode *mode,
+ struct drm_display_mode *adjusted_mode);
enum drm_mode_status drm_bridge_mode_valid(struct drm_bridge *bridge,
const struct drm_display_mode *mode);
void drm_bridge_disable(struct drm_bridge *bridge);
void drm_bridge_post_disable(struct drm_bridge *bridge);
void drm_bridge_mode_set(struct drm_bridge *bridge,
- struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode);
+ struct drm_display_mode *mode,
+ struct drm_display_mode *adjusted_mode);
void drm_bridge_pre_enable(struct drm_bridge *bridge);
void drm_bridge_enable(struct drm_bridge *bridge);

--
2.15.1



2018-05-16 09:45:38

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH] drm/bridge: checkpatch strict minor updates

On Tue, May 15, 2018 at 10:37:36PM +0200, Philippe Cornu wrote:
> Minor fixes detected with "scripts/checkpatch.pl --strict"
>
> Signed-off-by: Philippe Cornu <[email protected]>
> ---
> Detected when merging "drm: clarify adjusted_mode documentation for bridges"

Acked-by: Daniel Vetter <[email protected]>
>
> include/drm/drm_bridge.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index 9917651a7fdd..70131ab57e8f 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -97,7 +97,7 @@ struct drm_bridge_funcs {
> /**
> * @mode_fixup:
> *
> - * This callback is used to validate and adjust a mode. The paramater
> + * This callback is used to validate and adjust a mode. The parameter
> * mode is the display mode that should be fed to the next element in
> * the display chain, either the final &drm_connector or the next
> * &drm_bridge. The parameter adjusted_mode is the input mode the bridge
> @@ -301,15 +301,15 @@ int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
> struct drm_bridge *previous);
>
> bool drm_bridge_mode_fixup(struct drm_bridge *bridge,
> - const struct drm_display_mode *mode,
> - struct drm_display_mode *adjusted_mode);
> + const struct drm_display_mode *mode,
> + struct drm_display_mode *adjusted_mode);
> enum drm_mode_status drm_bridge_mode_valid(struct drm_bridge *bridge,
> const struct drm_display_mode *mode);
> void drm_bridge_disable(struct drm_bridge *bridge);
> void drm_bridge_post_disable(struct drm_bridge *bridge);
> void drm_bridge_mode_set(struct drm_bridge *bridge,
> - struct drm_display_mode *mode,
> - struct drm_display_mode *adjusted_mode);
> + struct drm_display_mode *mode,
> + struct drm_display_mode *adjusted_mode);
> void drm_bridge_pre_enable(struct drm_bridge *bridge);
> void drm_bridge_enable(struct drm_bridge *bridge);
>
> --
> 2.15.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2018-05-17 15:37:19

by Philippe Cornu

[permalink] [raw]
Subject: Re: [PATCH] drm/bridge: checkpatch strict minor updates

Hi,
Applied on drm-misc-next.
Note: patch subject has been renamed "drm/bridge: spelling and coding
style minor fixes" to comply with checkpatch (my bad ;-), hope it is
better, Many thanks,
Philippe :-)

On 05/16/2018 11:43 AM, Daniel Vetter wrote:
> On Tue, May 15, 2018 at 10:37:36PM +0200, Philippe Cornu wrote:
>> Minor fixes detected with "scripts/checkpatch.pl --strict"
>>
>> Signed-off-by: Philippe Cornu <[email protected]>
>> ---
>> Detected when merging "drm: clarify adjusted_mode documentation for bridges"
>
> Acked-by: Daniel Vetter <[email protected]>
>>
>> include/drm/drm_bridge.h | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
>> index 9917651a7fdd..70131ab57e8f 100644
>> --- a/include/drm/drm_bridge.h
>> +++ b/include/drm/drm_bridge.h
>> @@ -97,7 +97,7 @@ struct drm_bridge_funcs {
>> /**
>> * @mode_fixup:
>> *
>> - * This callback is used to validate and adjust a mode. The paramater
>> + * This callback is used to validate and adjust a mode. The parameter
>> * mode is the display mode that should be fed to the next element in
>> * the display chain, either the final &drm_connector or the next
>> * &drm_bridge. The parameter adjusted_mode is the input mode the bridge
>> @@ -301,15 +301,15 @@ int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
>> struct drm_bridge *previous);
>>
>> bool drm_bridge_mode_fixup(struct drm_bridge *bridge,
>> - const struct drm_display_mode *mode,
>> - struct drm_display_mode *adjusted_mode);
>> + const struct drm_display_mode *mode,
>> + struct drm_display_mode *adjusted_mode);
>> enum drm_mode_status drm_bridge_mode_valid(struct drm_bridge *bridge,
>> const struct drm_display_mode *mode);
>> void drm_bridge_disable(struct drm_bridge *bridge);
>> void drm_bridge_post_disable(struct drm_bridge *bridge);
>> void drm_bridge_mode_set(struct drm_bridge *bridge,
>> - struct drm_display_mode *mode,
>> - struct drm_display_mode *adjusted_mode);
>> + struct drm_display_mode *mode,
>> + struct drm_display_mode *adjusted_mode);
>> void drm_bridge_pre_enable(struct drm_bridge *bridge);
>> void drm_bridge_enable(struct drm_bridge *bridge);
>>
>> --
>> 2.15.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> [email protected]
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>