2018-05-16 19:31:09

by Mathieu Malaterre

Subject: [PATCH] tracing: make function ‘ftrace_exports’ static

In commit 478409dd683d ("tracing: Add hook to function tracing for other
subsystems to use"), a new function ‘ftrace_exports’ was added. Since
this function can be made static, make it so.

Silence the following warning triggered using W=1:

kernel/trace/trace.c:2451:6: warning: no previous prototype for ‘ftrace_exports’ [-Wmissing-prototypes]

Signed-off-by: Mathieu Malaterre <[email protected]>
---
kernel/trace/trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 414d7210b2ec..76b96f453cf7 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2448,7 +2448,7 @@ static inline void ftrace_exports_disable(void)
static_branch_disable(&ftrace_exports_enabled);
}

-void ftrace_exports(struct ring_buffer_event *event)
+static void ftrace_exports(struct ring_buffer_event *event)
{
struct trace_export *export;

--
2.11.0

2018-12-20 16:17:46

by Steven Rostedt

Subject: Re: [PATCH] tracing: make function ‘ftrace_exports’ static

Cleaning out my INBOX, I stumbled on this patch that slipped through
the cracks. Applied to my local queue.

Thanks, and sorry for the delay.

-- Steve


On Wed, 16 May 2018 21:30:12 +0200
Mathieu Malaterre <[email protected]> wrote:

> In commit 478409dd683d ("tracing: Add hook to function tracing for other
> subsystems to use"), a new function ‘ftrace_exports’ was added. Since
> this function can be made static, make it so.
>
> Silence the following warning triggered using W=1:
>
> kernel/trace/trace.c:2451:6: warning: no previous prototype for ‘ftrace_exports’ [-Wmissing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <[email protected]>
> ---
> kernel/trace/trace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 414d7210b2ec..76b96f453cf7 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2448,7 +2448,7 @@ static inline void ftrace_exports_disable(void)
> static_branch_disable(&ftrace_exports_enabled);
> }
>
> -void ftrace_exports(struct ring_buffer_event *event)
> +static void ftrace_exports(struct ring_buffer_event *event)
> {
> struct trace_export *export;
>