2018-05-18 16:33:47

by Vlad Buslov

[permalink] [raw]
Subject: [PATCH] tc-testing: fix ip address in u32 test

Fix expected ip address to actually match configured ip address.
Fix test to expect single matched filter.

Signed-off-by: Vlad Buslov <[email protected]>
---
tools/testing/selftests/tc-testing/tc-tests/filters/tests.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/tests.json b/tools/testing/selftests/tc-testing/tc-tests/filters/tests.json
index 5fa02d8..99a5ffc 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/filters/tests.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/filters/tests.json
@@ -12,8 +12,8 @@
"cmdUnderTest": "$TC filter add dev $DEV1 parent ffff: protocol ip prio 1 u32 match ip src 127.0.0.1/32 flowid 1:1 action ok",
"expExitCode": "0",
"verifyCmd": "$TC filter show dev $DEV1 parent ffff:",
- "matchPattern": "match 7f000002/ffffffff at 12",
- "matchCount": "0",
+ "matchPattern": "match 7f000001/ffffffff at 12",
+ "matchCount": "1",
"teardown": [
"$TC qdisc del dev $DEV1 ingress"
]
--
2.7.5



2018-05-22 15:46:53

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH] tc-testing: fix ip address in u32 test

On 05/18/2018 10:31 AM, Vlad Buslov wrote:
> Fix expected ip address to actually match configured ip address.
> Fix test to expect single matched filter.
>
> Signed-off-by: Vlad Buslov <[email protected]>

I can get this into 4.18-rc1 unless there is a reason for this to go
through net tree.

thanks,
-- Shuah