2018-06-25 08:01:03

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH] apalis_t30: fix can2

From: Marcel Ziswiler <[email protected]>

CAN2 currently fails on probe as follows:

mcp251x spi1.1: Probe failed, err=19

Fix this by enabling input on pin mux of resp. SPI4 pins.

Signed-off-by: Marcel Ziswiler <[email protected]>

---

arch/arm/boot/dts/tegra30-apalis.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
index d1d21ec2a844..9ff6aafd72b3 100644
--- a/arch/arm/boot/dts/tegra30-apalis.dtsi
+++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
@@ -118,6 +118,7 @@
nvidia,function = "spi4";
nvidia,pull = <TEGRA_PIN_PULL_NONE>;
nvidia,tristate = <TEGRA_PIN_DISABLE>;
+ nvidia,enable-input = <TEGRA_PIN_ENABLE>;
};
/* CAN_INT2 */
spi2_cs2_n_pw3 {
--
2.14.4



2018-07-23 09:48:37

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH] apalis_t30: fix can2

On 06/25/2018 09:59 AM, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
> CAN2 currently fails on probe as follows:
>
> mcp251x spi1.1: Probe failed, err=19
>
> Fix this by enabling input on pin mux of resp. SPI4 pins.
>
> Signed-off-by: Marcel Ziswiler <[email protected]>

I can take this via the linux-can tree. Any acks from the DT people?

Marc

>
> ---
>
> arch/arm/boot/dts/tegra30-apalis.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
> index d1d21ec2a844..9ff6aafd72b3 100644
> --- a/arch/arm/boot/dts/tegra30-apalis.dtsi
> +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
> @@ -118,6 +118,7 @@
> nvidia,function = "spi4";
> nvidia,pull = <TEGRA_PIN_PULL_NONE>;
> nvidia,tristate = <TEGRA_PIN_DISABLE>;
> + nvidia,enable-input = <TEGRA_PIN_ENABLE>;
> };
> /* CAN_INT2 */
> spi2_cs2_n_pw3 {
>


--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |

Attachments:
signature.asc (499.00 B)
OpenPGP digital signature

2018-07-23 10:20:21

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH] apalis_t30: fix can2

On 07/23/2018 10:16 AM, Marc Kleine-Budde wrote:
> On 06/25/2018 09:59 AM, Marcel Ziswiler wrote:
>> From: Marcel Ziswiler <[email protected]>
>>
>> CAN2 currently fails on probe as follows:
>>
>> mcp251x spi1.1: Probe failed, err=19
>>
>> Fix this by enabling input on pin mux of resp. SPI4 pins.
>>
>> Signed-off-by: Marcel Ziswiler <[email protected]>
>
> I can take this via the linux-can tree. Any acks from the DT people?

Never mind - it has been applied by Thierry menawhile:

> Applied to for-4.19/arm/dt, thanks.
>
> Thierry

sorry for the noise.
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |

Attachments:
signature.asc (499.00 B)
OpenPGP digital signature