2018-07-02 10:58:52

by Colin King

Subject: [PATCH] loop: remove redundant pointer inode

From: Colin Ian King <[email protected]>

Pointer inode is being assigned but is never used hence it is redundant
and can be removed.

Cleans up clang warning:
warning: variable 'inode' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/block/loop.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index d6b6f434fd4b..6e0b870308ee 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -690,7 +690,6 @@ static int loop_change_fd(struct loop_device *lo, struct block_device *bdev,
unsigned int arg)
{
struct file *file, *old_file;
- struct inode *inode;
int error;

error = -ENXIO;
@@ -711,7 +710,6 @@ static int loop_change_fd(struct loop_device *lo, struct block_device *bdev,
if (error)
goto out_putf;

- inode = file->f_mapping->host;
old_file = lo->lo_backing_file;

error = -EINVAL;
--
2.17.1

2018-07-02 14:28:11

by Jens Axboe

Subject: Re: [PATCH] loop: remove redundant pointer inode

On 7/2/18 1:47 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Pointer inode is being assigned but is never used hence it is redundant
> and can be removed.
>
> Cleans up clang warning:
> warning: variable 'inode' set but not used [-Wunused-but-set-variable]

Applied for 4.19, thanks.

--
Jens Axboe