2018-07-04 09:44:48

by Mariusz Bialonczyk

Subject: [PATCH] w1: fix w1_ds2438 documentation

Signed-off-by: Mariusz Bialonczyk <[email protected]>
---
Documentation/w1/slaves/w1_ds2438 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/w1/slaves/w1_ds2438
b/Documentation/w1/slaves/w1_ds2438
index b99f3674c5b4..e64f65a09387 100644
--- a/Documentation/w1/slaves/w1_ds2438
+++ b/Documentation/w1/slaves/w1_ds2438
@@ -60,4 +60,4 @@ vad: general purpose A/D input (VAD)
vdd: battery input (VDD)

After the voltage conversion the value is returned as decimal ASCII.
-Note: The value is in mV, so to get a volts the value has to be divided
by 10.
+Note: To get a volts the value has to be divided by 100.
--
2.16.2

2018-07-04 09:27:09

by Greg KH

Subject: Re: [PATCH] w1: fix w1_ds2438 documentation

On Wed, Jul 04, 2018 at 11:02:00AM +0200, manio wrote:
> Signed-off-by: Mariusz Bialonczyk <[email protected]>

I need a changelog text please.

> ---
> Documentation/w1/slaves/w1_ds2438 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/w1/slaves/w1_ds2438
> b/Documentation/w1/slaves/w1_ds2438
> index b99f3674c5b4..e64f65a09387 100644
> --- a/Documentation/w1/slaves/w1_ds2438
> +++ b/Documentation/w1/slaves/w1_ds2438
> @@ -60,4 +60,4 @@ vad: general purpose A/D input (VAD)
> vdd: battery input (VDD)
>
> After the voltage conversion the value is returned as decimal ASCII.
> -Note: The value is in mV, so to get a volts the value has to be divided by
> 10.
> +Note: To get a volts the value has to be divided by 100.

This does not look correct at all, are you sure about it?

greg k-h

2018-07-05 04:53:23

by Mariusz Bialonczyk

Subject: [PATCH v2] w1: fix w1_ds2438 documentation

The previous documentation was wrongly stating about the order
of magnitude of CONVERT_V result files contents (vad, vdd).
This commit is correcting this.

Reported-by: Adam Stolarczyk <[email protected]>
Signed-off-by: Mariusz Bialonczyk <[email protected]>
---

Resending as V2 because it was malformed by mail mail app recently.
I also added the Reported-by line and added a commit message
to describe the problem (to comply with Greg's review points).

Documentation/w1/slaves/w1_ds2438 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/w1/slaves/w1_ds2438 b/Documentation/w1/slaves/w1_ds2438
index b99f3674c5b4..e64f65a09387 100644
--- a/Documentation/w1/slaves/w1_ds2438
+++ b/Documentation/w1/slaves/w1_ds2438
@@ -60,4 +60,4 @@ vad: general purpose A/D input (VAD)
vdd: battery input (VDD)

After the voltage conversion the value is returned as decimal ASCII.
-Note: The value is in mV, so to get a volts the value has to be divided by 10.
+Note: To get a volts the value has to be divided by 100.
--
2.18.0