2018-07-06 15:57:18

by Nikunj Kela (nkela)

Subject: [PATCH] arm64: add ARM64-specific support for flatmem

Cc: [email protected]
Cc: Nikunj Kela <[email protected]>
Signed-off-by: Nikunj Kela <[email protected]>
---
arch/arm64/Kconfig | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 42c090c..5e791f0 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -775,6 +775,10 @@ config ARCH_SPARSEMEM_DEFAULT
config ARCH_SELECT_MEMORY_MODEL
def_bool ARCH_SPARSEMEM_ENABLE

+config ARCH_FLATMEM_ENABLE
+ def_bool y
+ depends on ARM64 && !NUMA
+
config HAVE_ARCH_PFN_VALID
def_bool ARCH_HAS_HOLES_MEMORYMODEL || !SPARSEMEM

--
2.10.3.dirty

2018-07-06 16:01:54

by Will Deacon

Subject: Re: [PATCH] arm64: add ARM64-specific support for flatmem

Please write a commit message for your patch.

On Fri, Jul 06, 2018 at 08:56:27AM -0700, Nikunj Kela wrote:
> Cc: [email protected]
> Cc: Nikunj Kela <[email protected]>
> Signed-off-by: Nikunj Kela <[email protected]>
> ---
> arch/arm64/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 42c090c..5e791f0 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -775,6 +775,10 @@ config ARCH_SPARSEMEM_DEFAULT
> config ARCH_SELECT_MEMORY_MODEL
> def_bool ARCH_SPARSEMEM_ENABLE
>
> +config ARCH_FLATMEM_ENABLE
> + def_bool y
> + depends on ARM64 && !NUMA

We don't need ARM64 here. I'm also not sure about the def_bool y, this seems
like a pretty niche thing to enable.

Will

2018-07-06 16:36:49

by Nikunj Kela (nkela)

Subject: Re: [PATCH] arm64: add ARM64-specific support for flatmem

Will modify the patch to remove ARM64. Every other architecture kept def_bool y for it so I followed the same for ARM64 too.

Thanks,
-Nikunj

On 7/6/18, 9:00 AM, "Will Deacon" <[email protected]> wrote:

Please write a commit message for your patch.

On Fri, Jul 06, 2018 at 08:56:27AM -0700, Nikunj Kela wrote:
> Cc: [email protected]
> Cc: Nikunj Kela <[email protected]>
> Signed-off-by: Nikunj Kela <[email protected]>
> ---
> arch/arm64/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 42c090c..5e791f0 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -775,6 +775,10 @@ config ARCH_SPARSEMEM_DEFAULT
> config ARCH_SELECT_MEMORY_MODEL
> def_bool ARCH_SPARSEMEM_ENABLE
>
> +config ARCH_FLATMEM_ENABLE
> + def_bool y
> + depends on ARM64 && !NUMA

We don't need ARM64 here. I'm also not sure about the def_bool y, this seems
like a pretty niche thing to enable.

Will