2018-08-14 20:50:41

by Tuomas Tynkkynen

Subject: [PATCH] ARM: dts: imx6: Add stdout-path to Wandboard

Setting a stdout-path in the .dtb is convenient because then the user
gets a serial console on the RS-232 connector without any extra effort
of figuring out the relevant 'console=' boot parameter.

Signed-off-by: Tuomas Tynkkynen <[email protected]>
---
Tested on a Wandboard Quad with mainline U-Boot 2018.05.
---
arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
index e1afa54404d0..0ef34c31f7c6 100644
--- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
@@ -8,6 +8,10 @@
#include <dt-bindings/gpio/gpio.h>

/ {
+ chosen {
+ stdout-path = &uart1;
+ };
+
regulators {
compatible = "simple-bus";
#address-cells = <1>;
--
2.16.3

2018-08-20 16:02:36

by Fabio Estevam

Subject: Re: [PATCH] ARM: dts: imx6: Add stdout-path to Wandboard

Hi Tuomas,

On Tue, Aug 14, 2018 at 5:47 PM, Tuomas Tynkkynen <[email protected]> wrote:
> Setting a stdout-path in the .dtb is convenient because then the user
> gets a serial console on the RS-232 connector without any extra effort
> of figuring out the relevant 'console=' boot parameter.
>
> Signed-off-by: Tuomas Tynkkynen <[email protected]>

Patch looks good.

Only a minor nit on the Subject line: I would do it like this to make
it consistent:

ARM: dts: imx6qdl-wandboard: Add stdout-path

Reviewed-by: Fabio Estevam <[email protected]>