2018-08-28 16:12:50

by Colin King

Subject: [PATCH] x86/xen: remove redundant variable save_pud

From: Colin Ian King <[email protected]>

Variable save_pud is being assigned but is never used hence it is
redundant and can be removed.

Cleans up clang warning:
variable 'save_pud' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <[email protected]>
---
arch/x86/xen/mmu_pv.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c
index 06a814d44b9b..2fe5c9b1816b 100644
--- a/arch/x86/xen/mmu_pv.c
+++ b/arch/x86/xen/mmu_pv.c
@@ -2060,7 +2060,6 @@ void __init xen_relocate_p2m(void)
pud_t *pud;
pgd_t *pgd;
unsigned long *new_p2m;
- int save_pud;

size = PAGE_ALIGN(xen_start_info->nr_pages * sizeof(unsigned long));
n_pte = roundup(size, PAGE_SIZE) >> PAGE_SHIFT;
@@ -2090,7 +2089,6 @@ void __init xen_relocate_p2m(void)

pgd = __va(read_cr3_pa());
new_p2m = (unsigned long *)(2 * PGDIR_SIZE);
- save_pud = n_pud;
for (idx_pud = 0; idx_pud < n_pud; idx_pud++) {
pud = early_memremap(pud_phys, PAGE_SIZE);
clear_page(pud);
--
2.17.1

2018-08-28 22:28:53

by Boris Ostrovsky

Subject: Re: [PATCH] x86/xen: remove redundant variable save_pud

On 08/28/2018 12:10 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Variable save_pud is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> variable 'save_pud' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <[email protected]>



Applied to for-linus-19b.

-boris