2003-11-24 08:06:16

by Eyal Lebedinsky

[permalink] [raw]
Subject: Re: Linux 2.6.0-test10 - BINFMT_ELF

It is unusual that a Y/n option includes M in the help text:
...
To compile this as a module, choose M here: the module will be called
binfmt_elf. Saying M or N here is dangerous because some crucial
programs on your system might be in ELF format.

Kernel support for ELF binaries (BINFMT_ELF) [Y/n/?] (NEW) y
...

--
Eyal Lebedinsky ([email protected]) <http://samba.org/eyal/>


2003-11-24 09:06:26

by Geoffrey Lee

[permalink] [raw]
Subject: Re: Linux 2.6.0-test10 - BINFMT_ELF

On Mon, Nov 24, 2003 at 07:06:09PM +1100, Eyal Lebedinsky wrote:
> It is unusual that a Y/n option includes M in the help text:
> ...
> To compile this as a module, choose M here: the module will be called
> binfmt_elf. Saying M or N here is dangerous because some crucial
> programs on your system might be in ELF format.
>
> Kernel support for ELF binaries (BINFMT_ELF) [Y/n/?] (NEW) y

I think Adrian had forgotten to update the help text.

- g.



Attachments:
(No filename) (453.00 B)
Kconfig.binfmt.patch (564.00 B)
Download all attachments

2003-11-24 14:26:18

by Adrian Bunk

[permalink] [raw]
Subject: Re: Linux 2.6.0-test10 - BINFMT_ELF

On Mon, Nov 24, 2003 at 05:05:07PM +0800, [email protected] wrote:
> On Mon, Nov 24, 2003 at 07:06:09PM +1100, Eyal Lebedinsky wrote:
> > It is unusual that a Y/n option includes M in the help text:
> > ...
> > To compile this as a module, choose M here: the module will be called
> > binfmt_elf. Saying M or N here is dangerous because some crucial
> > programs on your system might be in ELF format.
> >
> > Kernel support for ELF binaries (BINFMT_ELF) [Y/n/?] (NEW) y
>
> I think Adrian had forgotten to update the help text.


Yes, your patch is obviously correct.


> - g.
>
>

> --- linux-2.6.0-test10/fs/Kconfig.binfmt.orig 2003-11-24 16:44:36.000000000 +0800
> +++ linux-2.6.0-test10/fs/Kconfig.binfmt 2003-11-24 16:45:10.000000000 +0800
> @@ -23,10 +23,6 @@
> ld.so (check the file <file:Documentation/Changes> for location and
> latest version).
>
> - To compile this as a module, choose M here: the module will be called
> - binfmt_elf. Saying M or N here is dangerous because some crucial
> - programs on your system might be in ELF format.
> -
> config BINFMT_FLAT
> tristate "Kernel support for flat binaries"
> depends on !MMU || SUPERH


cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed