Jeff Garzik <[email protected]>:
> FWIW I am opposed to any large-scale cleanup of the configuration
> language and/or identifiers in -any- 2.4.x series kernel.
This is tweaking 39 symbols out of 1831, hardly large-scale. These
irregularities in the namespace cause trouble out of all proportion to
their size, is my problem. If you knew what I've been through trying
to write analysis tools...*shudder*...
> Not only C code but installer utilities are affected by changes in the
> CONFIG_xxx identifiers. If we change that namespace, we are changing
> part of the API that is exported to drivers. Definitely not 2.4.x
> stuff.
My patch fixes those installer utilities. All three of them. And no driver
code is or possibly could be broken by it, that's a red herring. *No
object code will change as a result of this patch*.
> If we are moving to CML2 in 2.5, I see no point in big CML1 cleanups.
Yes, I know, that's what I said about Peter's DERIVED patch a week ago.
You notice *he* ain't bitching about this one?
I want this in before the 2.5 fork for several reasons:
(1) 19 of the 39 changes fix things that are outright bugs even in CML1.
These should not be allowed to persist in the stable branch.
(2) I want to finish my analysis tools and do some really thorough
consistency and correctness checking before the stable branch
separates. Alan will thank me for this later.
(2) If we do adopt CML2, having these changes in will make it *far*
easier to contemplate back-porting it to 2.4.x later on.
The present configuration system is a mess, everybody agrees on that.
I'm trying to clean it up, and it's a tedious and grubby enough job
even with the full cooperation of the kbuild team. Jeff, would you
please support this instead of obstructing it?
--
<a href="http://www.tuxedo.org/~esr/">Eric S. Raymond</a>
"You have taught us much. Come with us and join the movement."
"This movement of yours, does it have slogans?" inquired the Chink.
"Right on!" they cried. And they quoted him some.
"Your movement, does it have a flag?" asked the Chink.
"You bet!" and they described their emblem.
"And does your movement have leaders?"
"Great leaders."
"Then shove it up your butts," said the Chink. "I have taught you nothing."
-- Tom Robbins, "Even Cowgirls Get The Blues"
On Mon, 26 Mar 2001 02:09:02 -0500,
"Eric S. Raymond" <[email protected]> wrote:
>Jeff Garzik <[email protected]>:
>> If we are moving to CML2 in 2.5, I see no point in big CML1 cleanups.
>
>Yes, I know, that's what I said about Peter's DERIVED patch a week ago.
Hey, that was my DERIVED patch, not Peter's. Point the blame where it
is due, even I think that my patch was a bad idea. -ENOTENOUGHCOFFEE.
The 20 cris variables must be renamed to CONFIG_xxx, otherwise make dep
will not find them and config changes will only cause partial
recompiles - or do the cris people like inconsistent kernels?
Correcting the two old names is obviously the right thing to do.
That just leaves the 17 names of the form CONFIG_[0-9]*. Only the 8139
is likely to affect outside the kernel and the argument that renaming
config options might affect external packages does not hold. The
recent aic7xxx change broke pcmcia on 2.2 kernels but we can work round
it.
Keith Owens wrote:
> That just leaves the 17 names of the form CONFIG_[0-9]*. Only the 8139
> is likely to affect outside the kernel and the argument that renaming
> config options might affect external packages does not hold. The
> recent aic7xxx change broke pcmcia on 2.2 kernels but we can work round
> it.
There is no good reason to restrict the CML2 identifier namespace.
This is a policy change not a cleanup.
--
Jeff Garzik | May you have warm words on a cold evening,
Building 1024 | a full moon on a dark night,
MandrakeSoft | and a smooth road all the way to your door.
Jeff Garzik <[email protected]>:
> There is no good reason to restrict the CML2 identifier namespace.
I've already listed a couple of good reasons. As Peter said, maintanicus
selector est.
--
<a href="http://www.tuxedo.org/~esr/">Eric S. Raymond</a>
No one who's seen it in action can say the phrase "government help" without
either laughing or crying.