2018-11-02 02:58:19

by Olof Johansson

[permalink] [raw]
Subject: [PATCH] pinctrl: mediatek: Fix dependencies for EINT_MTK

Fixes the following config-time warning:

WARNING: unmet direct dependencies detected for EINT_MTK
Depends on [n]: PINCTRL [=y] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && (PINCTRL_MTK [=n] || PINCTRL_MTK_MOORE [=n] || COMPILE_TEST [=n])
Selected by [y]:
- PINCTRL_MTK_PARIS [=y] && PINCTRL [=y] && OF [=y] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n])

Fixes: 805250982bb5 ("pinctrl: mediatek: add pinctrl-paris that implements the vendor dt-bindings")
Signed-off-by: Olof Johansson <[email protected]>
---
drivers/pinctrl/mediatek/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
index 9d142e1da567..50efc9cc8ee7 100644
--- a/drivers/pinctrl/mediatek/Kconfig
+++ b/drivers/pinctrl/mediatek/Kconfig
@@ -3,7 +3,7 @@ menu "MediaTek pinctrl drivers"

config EINT_MTK
bool "MediaTek External Interrupt Support"
- depends on PINCTRL_MTK || PINCTRL_MTK_MOORE || COMPILE_TEST
+ depends on PINCTRL_MTK || PINCTRL_MTK_MOORE || PINCTRL_MTK_PARIS || COMPILE_TEST
select GPIOLIB
select IRQ_DOMAIN

--
2.11.0



2018-11-07 10:01:46

by Sean Wang

[permalink] [raw]
Subject: Re: [PATCH] pinctrl: mediatek: Fix dependencies for EINT_MTK

Thanks for the catch.

Acked-by: Sean Wang <[email protected]>

On Thu, Nov 1, 2018 at 7:57 PM Olof Johansson <[email protected]> wrote:
>
> Fixes the following config-time warning:
>
> WARNING: unmet direct dependencies detected for EINT_MTK
> Depends on [n]: PINCTRL [=y] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && (PINCTRL_MTK [=n] || PINCTRL_MTK_MOORE [=n] || COMPILE_TEST [=n])
> Selected by [y]:
> - PINCTRL_MTK_PARIS [=y] && PINCTRL [=y] && OF [=y] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n])
>
> Fixes: 805250982bb5 ("pinctrl: mediatek: add pinctrl-paris that implements the vendor dt-bindings")
> Signed-off-by: Olof Johansson <[email protected]>
> ---
> drivers/pinctrl/mediatek/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
> index 9d142e1da567..50efc9cc8ee7 100644
> --- a/drivers/pinctrl/mediatek/Kconfig
> +++ b/drivers/pinctrl/mediatek/Kconfig
> @@ -3,7 +3,7 @@ menu "MediaTek pinctrl drivers"
>
> config EINT_MTK
> bool "MediaTek External Interrupt Support"
> - depends on PINCTRL_MTK || PINCTRL_MTK_MOORE || COMPILE_TEST
> + depends on PINCTRL_MTK || PINCTRL_MTK_MOORE || PINCTRL_MTK_PARIS || COMPILE_TEST
> select GPIOLIB
> select IRQ_DOMAIN
>
> --
> 2.11.0
>

2018-11-15 09:27:22

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] pinctrl: mediatek: Fix dependencies for EINT_MTK

On Fri, Nov 2, 2018 at 3:57 AM Olof Johansson <[email protected]> wrote:

> Fixes the following config-time warning:
>
> WARNING: unmet direct dependencies detected for EINT_MTK
> Depends on [n]: PINCTRL [=y] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && (PINCTRL_MTK [=n] || PINCTRL_MTK_MOORE [=n] || COMPILE_TEST [=n])
> Selected by [y]:
> - PINCTRL_MTK_PARIS [=y] && PINCTRL [=y] && OF [=y] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n])
>
> Fixes: 805250982bb5 ("pinctrl: mediatek: add pinctrl-paris that implements the vendor dt-bindings")
> Signed-off-by: Olof Johansson <[email protected]>

Patch applied with Sean's ACK!

Yours,
Linus Walleij