2018-11-02 21:18:07

by Rasmus Villemoes

Subject: [PATCH] macintosh: ans-lcd: make anslcd_logo static and __initconst

This variable has no reason to have external linkage, and since it is
only used in an __init function, it might as well be made __initconst
also.

Signed-off-by: Rasmus Villemoes <[email protected]>
---
drivers/macintosh/ans-lcd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c
index c8e078b911c7..a7a79a935f6a 100644
--- a/drivers/macintosh/ans-lcd.c
+++ b/drivers/macintosh/ans-lcd.c
@@ -147,7 +147,8 @@ static struct miscdevice anslcd_dev = {
&anslcd_fops
};

-const char anslcd_logo[] = "********************" /* Line #1 */
+static const char anslcd_logo[] __initconst =
+ "********************" /* Line #1 */
"* LINUX! *" /* Line #3 */
"* Welcome to *" /* Line #2 */
"********************"; /* Line #4 */
--
2.19.1.6.gbde171bbf5

2019-11-14 09:10:48

by Michael Ellerman

Subject: Re: [PATCH] macintosh: ans-lcd: make anslcd_logo static and __initconst

On Fri, 2018-11-02 at 21:17:06 UTC, Rasmus Villemoes wrote:
> This variable has no reason to have external linkage, and since it is
> only used in an __init function, it might as well be made __initconst
> also.
>
> Signed-off-by: Rasmus Villemoes <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/3775026a654c15c92c8ac2d53f3fd14fdd1980df

cheers