2018-11-03 05:25:58

by Sabyasachi Gupta

Subject: [PATCH] arch/sparc: Use kzalloc_node

Replaced kmalloc_node + memset with kzalloc_node

Signed-off-by: Sabyasachi Gupta <[email protected]>
---
arch/sparc/kernel/iommu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/sparc/kernel/iommu.c b/arch/sparc/kernel/iommu.c
index 40d008b..05eb016 100644
--- a/arch/sparc/kernel/iommu.c
+++ b/arch/sparc/kernel/iommu.c
@@ -108,10 +108,9 @@ int iommu_table_init(struct iommu *iommu, int tsbsize,
/* Allocate and initialize the free area map. */
sz = num_tsb_entries / 8;
sz = (sz + 7UL) & ~7UL;
- iommu->tbl.map = kmalloc_node(sz, GFP_KERNEL, numa_node);
+ iommu->tbl.map = kzalloc_node(sz, GFP_KERNEL, numa_node);
if (!iommu->tbl.map)
return -ENOMEM;
- memset(iommu->tbl.map, 0, sz);

iommu_tbl_pool_init(&iommu->tbl, num_tsb_entries, IO_PAGE_SHIFT,
(tlb_type != hypervisor ? iommu_flushall : NULL),
--
2.7.4

2018-11-15 17:55:03

by Sabyasachi Gupta

Subject: Re: [PATCH] arch/sparc: Use kzalloc_node

On Sat, Nov 3, 2018 at 10:54 AM Sabyasachi Gupta
<[email protected]> wrote:
>
> Replaced kmalloc_node + memset with kzalloc_node
>
> Signed-off-by: Sabyasachi Gupta <[email protected]>

Any comment on this patch?

> ---
> arch/sparc/kernel/iommu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/sparc/kernel/iommu.c b/arch/sparc/kernel/iommu.c
> index 40d008b..05eb016 100644
> --- a/arch/sparc/kernel/iommu.c
> +++ b/arch/sparc/kernel/iommu.c
> @@ -108,10 +108,9 @@ int iommu_table_init(struct iommu *iommu, int tsbsize,
> /* Allocate and initialize the free area map. */
> sz = num_tsb_entries / 8;
> sz = (sz + 7UL) & ~7UL;
> - iommu->tbl.map = kmalloc_node(sz, GFP_KERNEL, numa_node);
> + iommu->tbl.map = kzalloc_node(sz, GFP_KERNEL, numa_node);
> if (!iommu->tbl.map)
> return -ENOMEM;
> - memset(iommu->tbl.map, 0, sz);
>
> iommu_tbl_pool_init(&iommu->tbl, num_tsb_entries, IO_PAGE_SHIFT,
> (tlb_type != hypervisor ? iommu_flushall : NULL),
> --
> 2.7.4
>

2018-11-15 18:06:54

by David Miller

Subject: Re: [PATCH] arch/sparc: Use kzalloc_node

From: Sabyasachi Gupta <[email protected]>
Date: Thu, 15 Nov 2018 23:23:42 +0530

> On Sat, Nov 3, 2018 at 10:54 AM Sabyasachi Gupta
> <[email protected]> wrote:
>>
>> Replaced kmalloc_node + memset with kzalloc_node
>>
>> Signed-off-by: Sabyasachi Gupta <[email protected]>
>
> Any comment on this patch?

Just too busy to get to it and am at plumbers this week.

Will try to look at it next week.

2018-11-19 03:02:58

by David Miller

Subject: Re: [PATCH] arch/sparc: Use kzalloc_node

From: Sabyasachi Gupta <[email protected]>
Date: Sat, 3 Nov 2018 10:54:52 +0530

> Replaced kmalloc_node + memset with kzalloc_node
>
> Signed-off-by: Sabyasachi Gupta <[email protected]>

Applied.