2004-01-16 19:31:37

by Eduard Roccatello

Subject: p4-clockmod does not compile under 2.6.1-mm3

Hello :-)

bash-2.05b# gcc --version
gcc (GCC) 3.2.3

bash-2.05b# make
SPLIT include/linux/autoconf.h -> include/config/*
make[1]: `arch/i386/kernel/asm-offsets.s' is up to date.
CHK include/linux/compile.h
CC arch/i386/kernel/cpu/cpufreq/p4-clockmod.o
arch/i386/kernel/cpu/cpufreq/p4-clockmod.c: In function `cpufreq_p4_setdc':
arch/i386/kernel/cpu/cpufreq/p4-clockmod.c:71: `cpu_sibling_map' undeclared
(first use in this function)
arch/i386/kernel/cpu/cpufreq/p4-clockmod.c:71: (Each undeclared identifier
is reported only once
arch/i386/kernel/cpu/cpufreq/p4-clockmod.c:71: for each function it appears
in.)
make[3]: *** [arch/i386/kernel/cpu/cpufreq/p4-clockmod.o] Error 1
make[2]: *** [arch/i386/kernel/cpu/cpufreq] Error 2
make[1]: *** [arch/i386/kernel/cpu] Error 2
make: *** [arch/i386/kernel] Error 2

adding a cpumask_t cpu_sibling_map[NR_CPUS] to the function make it compile
but i think this is a very bad solution (sorry I'm not a kernel hacker :-)


Thanks,
Eduard

2004-01-16 22:48:32

by Daniel Kirsten

Subject: Re: p4-clockmod does not compile under 2.6.1-mm3

You should enable

Pentium-4/Celeron(P4-based)/Pentium-4 M/Xeon

under Processor type and features --> Processor support.

2004-01-17 00:41:17

by Adrian Bunk

Subject: Re: p4-clockmod does not compile under 2.6.1-mm3

On Fri, Jan 16, 2004 at 08:14:24PM +0100, Eduard Roccatello wrote:

> Hello :-)

Hi Eduard,

> bash-2.05b# gcc --version
> gcc (GCC) 3.2.3
>
> bash-2.05b# make
> SPLIT include/linux/autoconf.h -> include/config/*
> make[1]: `arch/i386/kernel/asm-offsets.s' is up to date.
> CHK include/linux/compile.h
> CC arch/i386/kernel/cpu/cpufreq/p4-clockmod.o
> arch/i386/kernel/cpu/cpufreq/p4-clockmod.c: In function `cpufreq_p4_setdc':
> arch/i386/kernel/cpu/cpufreq/p4-clockmod.c:71: `cpu_sibling_map' undeclared
> (first use in this function)
> arch/i386/kernel/cpu/cpufreq/p4-clockmod.c:71: (Each undeclared identifier
> is reported only once
> arch/i386/kernel/cpu/cpufreq/p4-clockmod.c:71: for each function it appears
> in.)
> make[3]: *** [arch/i386/kernel/cpu/cpufreq/p4-clockmod.o] Error 1
> make[2]: *** [arch/i386/kernel/cpu/cpufreq] Error 2
> make[1]: *** [arch/i386/kernel/cpu] Error 2
> make: *** [arch/i386/kernel] Error 2
>
> adding a cpumask_t cpu_sibling_map[NR_CPUS] to the function make it compile
> but i think this is a very bad solution (sorry I'm not a kernel hacker :-)


thanks for your report.

This was a known bug in -mm3 that is already fixed in -mm4 [1].


> Thanks,
> Eduard

cu
Adrian

[1] ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.1/2.6.1-mm4/broken-out/p4-clockmod-sibling-map-fix.patch

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed