2004-01-23 06:38:52

by Dave Jones

[permalink] [raw]
Subject: PCI probing typo?

Looking at this code, I can't convince myself it's
currently doing the right thing. It looks more like
the intention was one of the two below..

Dave

diff -urpN --exclude-from=/home/davej/.exclude bk-linus/arch/i386/pci/direct.c linux-2.5/arch/i386/pci/direct.c
--- bk-linus/arch/i386/pci/direct.c 2003-09-29 19:45:06.000000000 +0100
+++ linux-2.5/arch/i386/pci/direct.c 2004-01-05 05:54:04.000000000 +0000
@@ -259,7 +259,7 @@ static int __init pci_direct_init(void)
release_resource(region);

type2:
- if ((!pci_probe & PCI_PROBE_CONF2) == 0)
+ if ((pci_probe & PCI_PROBE_CONF2) == 0)
goto out;
region = request_region(0xCF8, 4, "PCI conf2");
if (!region)