2018-12-22 17:55:32

by Alistair Francis

[permalink] [raw]
Subject: [PATCH v2] RISC-V: defconfig: Enable Generic PCIE by default

Enable generic PCIe by default in the RISC-V defconfig, this allows us
to use QEMU's PCIe support out of the box.

Signed-off-by: Alistair Francis <[email protected]>
---
v2:
- Keep the Xilinx PCIE enabled

arch/riscv/configs/defconfig | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
index ef4f15df9adf..2186d4ee1d4e 100644
--- a/arch/riscv/configs/defconfig
+++ b/arch/riscv/configs/defconfig
@@ -14,6 +14,13 @@ CONFIG_EXPERT=y
CONFIG_BPF_SYSCALL=y
CONFIG_SMP=y
CONFIG_PCI=y
+CONFIG_PCI_ECAM=y
+CONFIG_PCI_HOST_COMMON=y
+CONFIG_PCI_HOST_GENERIC=y
+CONFIG_PCIEPORTBUS=y
+CONFIG_PCIEAER=y
+CONFIG_PCIEASPM=y
+CONFIG_PCIEASPM_DEFAULT=y
CONFIG_PCIE_XILINX=y
CONFIG_MODULES=y
CONFIG_MODULE_UNLOAD=y
--
2.19.1



2018-12-23 09:41:18

by Paul Walmsley

[permalink] [raw]
Subject: Re: [PATCH v2] RISC-V: defconfig: Enable Generic PCIE by default

(fixed "Palmpalmer" again, might want to check your script for sending
patches)

On Fri, 21 Dec 2018, Alistair Francis wrote:

> Enable generic PCIe by default in the RISC-V defconfig, this allows us
> to use QEMU's PCIe support out of the box.
>
> Signed-off-by: Alistair Francis <[email protected]>

Thanks for updating this.

I tried applying it against v4.20-rc7 and running "make savedefconfig",
and there is a delta. It is better if there is no delta. Is this patch
based on a different commit? Or, is this patch not the product of "make
savedefconfig"? If the latter, please do:

make savedefconfig
cp defconfig arch/riscv/configs/defconfig

to clean up the diff.

thanks

- Paul