2018-12-30 19:57:36

by Sinan Kaya

Subject: [PATCH v4 03/11] vga-switcheroo: make PCI dependency explicit

This driver depends on the PCI infrastructure but the dependency has not
been explicitly called out.

Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <[email protected]>
Reviewed-by: Lukas Wunner <[email protected]>
Acked-by: Daniel Vetter <[email protected]>
---
drivers/gpu/vga/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
index b677e5d524e6..d5f1d8e1c6f8 100644
--- a/drivers/gpu/vga/Kconfig
+++ b/drivers/gpu/vga/Kconfig
@@ -21,6 +21,7 @@ config VGA_SWITCHEROO
bool "Laptop Hybrid Graphics - GPU switching support"
depends on X86
depends on ACPI
+ depends on PCI
select VGA_ARB
help
Many laptops released in 2008/9/10 have two GPUs with a multiplexer
--
2.19.0

2019-01-07 10:36:14

by Daniel Vetter

Subject: Re: [PATCH v4 03/11] vga-switcheroo: make PCI dependency explicit

On Sun, Dec 30, 2018 at 07:56:04PM +0000, Sinan Kaya wrote:
> This driver depends on the PCI infrastructure but the dependency has not
> been explicitly called out.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <[email protected]>
> Reviewed-by: Lukas Wunner <[email protected]>
> Acked-by: Daniel Vetter <[email protected]>

I'm assuming this goes in through the acpi tree, correct?
-Daniel

> ---
> drivers/gpu/vga/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
> index b677e5d524e6..d5f1d8e1c6f8 100644
> --- a/drivers/gpu/vga/Kconfig
> +++ b/drivers/gpu/vga/Kconfig
> @@ -21,6 +21,7 @@ config VGA_SWITCHEROO
> bool "Laptop Hybrid Graphics - GPU switching support"
> depends on X86
> depends on ACPI
> + depends on PCI
> select VGA_ARB
> help
> Many laptops released in 2008/9/10 have two GPUs with a multiplexer
> --
> 2.19.0
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2019-01-07 10:57:25

by Rafael J. Wysocki

Subject: Re: [PATCH v4 03/11] vga-switcheroo: make PCI dependency explicit

On Mon, Jan 7, 2019 at 11:34 AM Daniel Vetter <[email protected]> wrote:
>
> On Sun, Dec 30, 2018 at 07:56:04PM +0000, Sinan Kaya wrote:
> > This driver depends on the PCI infrastructure but the dependency has not
> > been explicitly called out.
> >
> > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> > Signed-off-by: Sinan Kaya <[email protected]>
> > Reviewed-by: Lukas Wunner <[email protected]>
> > Acked-by: Daniel Vetter <[email protected]>
>
> I'm assuming this goes in through the acpi tree, correct?

I'm going to pick it up.