2019-01-09 05:51:05

by Peng Hao

Subject: [PATCH] rcu: Remove rcu_*_state declaration

Because of just only one set of rcu_state, the declaration of
rcu_sched_state/rcu_bh_state/rcu_preempt_state is unnecessary.

Signed-off-by: Peng Hao <[email protected]>
---
kernel/rcu/tree.h | 7 -------
1 file changed, 7 deletions(-)

diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
index 703e19f..9ea704c 100644
--- a/kernel/rcu/tree.h
+++ b/kernel/rcu/tree.h
@@ -401,13 +401,6 @@ struct rcu_state {
/*
* RCU implementation internal declarations:
*/
-extern struct rcu_state rcu_sched_state;
-
-extern struct rcu_state rcu_bh_state;
-
-#ifdef CONFIG_PREEMPT_RCU
-extern struct rcu_state rcu_preempt_state;
-#endif /* #ifdef CONFIG_PREEMPT_RCU */

int rcu_dynticks_snap(struct rcu_data *rdp);

--
1.8.3.1

2019-01-09 13:56:49

by Paul E. McKenney

Subject: Re: [PATCH] rcu: Remove rcu_*_state declaration

On Wed, Jan 09, 2019 at 10:13:28PM +0800, Peng Hao wrote:
> Because of just only one set of rcu_state, the declaration of
> rcu_sched_state/rcu_bh_state/rcu_preempt_state is unnecessary.
>
> Signed-off-by: Peng Hao <[email protected]>

This does not apply to my current -rcu tree. Please see branch "dev"
of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git.

Thanx, Paul

> ---
> kernel/rcu/tree.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
> index 703e19f..9ea704c 100644
> --- a/kernel/rcu/tree.h
> +++ b/kernel/rcu/tree.h
> @@ -401,13 +401,6 @@ struct rcu_state {
> /*
> * RCU implementation internal declarations:
> */
> -extern struct rcu_state rcu_sched_state;
> -
> -extern struct rcu_state rcu_bh_state;
> -
> -#ifdef CONFIG_PREEMPT_RCU
> -extern struct rcu_state rcu_preempt_state;
> -#endif /* #ifdef CONFIG_PREEMPT_RCU */
>
> int rcu_dynticks_snap(struct rcu_data *rdp);
>
> --
> 1.8.3.1
>