2019-01-10 07:12:31

by Sabyasachi Gupta

Subject: [PATCH] drivers/usb/storage: Remove duplicate headers

Remove duplicate headers which are included more than once.

Signed-off-by: Sabyasachi Gupta <[email protected]>
---
drivers/usb/storage/datafab.c | 1 -
drivers/usb/storage/ene_ub6250.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/usb/storage/datafab.c b/drivers/usb/storage/datafab.c
index 09353be..4b1bd56 100644
--- a/drivers/usb/storage/datafab.c
+++ b/drivers/usb/storage/datafab.c
@@ -102,7 +102,6 @@ MODULE_DEVICE_TABLE(usb, datafab_usb_ids);
}

static struct us_unusual_dev datafab_unusual_dev_list[] = {
-# include "unusual_datafab.h"
{ } /* Terminating entry */
};

diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c
index 4d261e4..79a07bf 100644
--- a/drivers/usb/storage/ene_ub6250.c
+++ b/drivers/usb/storage/ene_ub6250.c
@@ -65,7 +65,6 @@ MODULE_DEVICE_TABLE(usb, ene_ub6250_usb_ids);
}

static struct us_unusual_dev ene_ub6250_unusual_dev_list[] = {
-# include "unusual_ene_ub6250.h"
{ } /* Terminating entry */
};

--
2.7.4

2019-01-11 09:29:55

by Greg Kroah-Hartman

Subject: Re: [PATCH] drivers/usb/storage: Remove duplicate headers

On Thu, Jan 10, 2019 at 12:40:07PM +0530, Sabyasachi Gupta wrote:
> Remove duplicate headers which are included more than once.
>
> Signed-off-by: Sabyasachi Gupta <[email protected]>
> ---
> drivers/usb/storage/datafab.c | 1 -
> drivers/usb/storage/ene_ub6250.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/usb/storage/datafab.c b/drivers/usb/storage/datafab.c
> index 09353be..4b1bd56 100644
> --- a/drivers/usb/storage/datafab.c
> +++ b/drivers/usb/storage/datafab.c
> @@ -102,7 +102,6 @@ MODULE_DEVICE_TABLE(usb, datafab_usb_ids);
> }
>
> static struct us_unusual_dev datafab_unusual_dev_list[] = {
> -# include "unusual_datafab.h"
> { } /* Terminating entry */
> };

Nope, this breaks things :(