Minor clean-up to use BIT() and keep checkpatch happy. Clean up the
comment formatting while we're at it to make it easier to read.
Signed-off-by: Amit Kucheria <[email protected]>
Reviewed-by: Stephen Boyd <[email protected]>
---
include/linux/cpufreq.h | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
index c86d6d8bdfed..bd7fbd6a4478 100644
--- a/include/linux/cpufreq.h
+++ b/include/linux/cpufreq.h
@@ -346,14 +346,15 @@ struct cpufreq_driver {
};
/* flags */
-#define CPUFREQ_STICKY (1 << 0) /* driver isn't removed even if
- all ->init() calls failed */
-#define CPUFREQ_CONST_LOOPS (1 << 1) /* loops_per_jiffy or other
- kernel "constants" aren't
- affected by frequency
- transitions */
-#define CPUFREQ_PM_NO_WARN (1 << 2) /* don't warn on suspend/resume
- speed mismatches */
+
+/* driver isn't removed even if all ->init() calls failed */
+#define CPUFREQ_STICKY BIT(0)
+
+/* loops_per_jiffy or other kernel "constants" aren't affected by frequency transitions */
+#define CPUFREQ_CONST_LOOPS BIT(1)
+
+/* don't warn on suspend/resume speed mismatches */
+#define CPUFREQ_PM_NO_WARN BIT(2)
/*
* This should be set by platforms having multiple clock-domains, i.e.
@@ -361,14 +362,14 @@ struct cpufreq_driver {
* be created in cpu/cpu<num>/cpufreq/ directory and so they can use the same
* governor with different tunables for different clusters.
*/
-#define CPUFREQ_HAVE_GOVERNOR_PER_POLICY (1 << 3)
+#define CPUFREQ_HAVE_GOVERNOR_PER_POLICY BIT(3)
/*
* Driver will do POSTCHANGE notifications from outside of their ->target()
* routine and so must set cpufreq_driver->flags with this flag, so that core
* can handle them specially.
*/
-#define CPUFREQ_ASYNC_NOTIFICATION (1 << 4)
+#define CPUFREQ_ASYNC_NOTIFICATION BIT(4)
/*
* Set by drivers which want cpufreq core to check if CPU is running at a
@@ -377,13 +378,13 @@ struct cpufreq_driver {
* from the table. And if that fails, we will stop further boot process by
* issuing a BUG_ON().
*/
-#define CPUFREQ_NEED_INITIAL_FREQ_CHECK (1 << 5)
+#define CPUFREQ_NEED_INITIAL_FREQ_CHECK BIT(5)
/*
* Set by drivers to disallow use of governors with "dynamic_switching" flag
* set.
*/
-#define CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING (1 << 6)
+#define CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING BIT(6)
int cpufreq_register_driver(struct cpufreq_driver *driver_data);
int cpufreq_unregister_driver(struct cpufreq_driver *driver_data);
--
2.17.1
On Monday, January 21, 2019 9:47:37 AM CET Amit Kucheria wrote:
> Minor clean-up to use BIT() and keep checkpatch happy. Clean up the
> comment formatting while we're at it to make it easier to read.
>
> Signed-off-by: Amit Kucheria <[email protected]>
> Reviewed-by: Stephen Boyd <[email protected]>
> ---
> include/linux/cpufreq.h | 25 +++++++++++++------------
> 1 file changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index c86d6d8bdfed..bd7fbd6a4478 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -346,14 +346,15 @@ struct cpufreq_driver {
> };
>
> /* flags */
> -#define CPUFREQ_STICKY (1 << 0) /* driver isn't removed even if
> - all ->init() calls failed */
> -#define CPUFREQ_CONST_LOOPS (1 << 1) /* loops_per_jiffy or other
> - kernel "constants" aren't
> - affected by frequency
> - transitions */
> -#define CPUFREQ_PM_NO_WARN (1 << 2) /* don't warn on suspend/resume
> - speed mismatches */
> +
> +/* driver isn't removed even if all ->init() calls failed */
> +#define CPUFREQ_STICKY BIT(0)
> +
> +/* loops_per_jiffy or other kernel "constants" aren't affected by frequency transitions */
> +#define CPUFREQ_CONST_LOOPS BIT(1)
> +
> +/* don't warn on suspend/resume speed mismatches */
> +#define CPUFREQ_PM_NO_WARN BIT(2)
>
> /*
> * This should be set by platforms having multiple clock-domains, i.e.
> @@ -361,14 +362,14 @@ struct cpufreq_driver {
> * be created in cpu/cpu<num>/cpufreq/ directory and so they can use the same
> * governor with different tunables for different clusters.
> */
> -#define CPUFREQ_HAVE_GOVERNOR_PER_POLICY (1 << 3)
> +#define CPUFREQ_HAVE_GOVERNOR_PER_POLICY BIT(3)
>
> /*
> * Driver will do POSTCHANGE notifications from outside of their ->target()
> * routine and so must set cpufreq_driver->flags with this flag, so that core
> * can handle them specially.
> */
> -#define CPUFREQ_ASYNC_NOTIFICATION (1 << 4)
> +#define CPUFREQ_ASYNC_NOTIFICATION BIT(4)
>
> /*
> * Set by drivers which want cpufreq core to check if CPU is running at a
> @@ -377,13 +378,13 @@ struct cpufreq_driver {
> * from the table. And if that fails, we will stop further boot process by
> * issuing a BUG_ON().
> */
> -#define CPUFREQ_NEED_INITIAL_FREQ_CHECK (1 << 5)
> +#define CPUFREQ_NEED_INITIAL_FREQ_CHECK BIT(5)
>
> /*
> * Set by drivers to disallow use of governors with "dynamic_switching" flag
> * set.
> */
> -#define CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING (1 << 6)
> +#define CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING BIT(6)
>
> int cpufreq_register_driver(struct cpufreq_driver *driver_data);
> int cpufreq_unregister_driver(struct cpufreq_driver *driver_data);
>
Applied, thanks!