2004-03-07 15:50:24

by Adrian Bunk

[permalink] [raw]
Subject: [2.4 patch] MAINTAINERS: remove LAN media entry

On Sat, Feb 28, 2004 at 11:57:11AM +0100, Daniel Egger wrote:
> On Feb 27, 2004, at 9:54 pm, Adrian Bunk wrote:
>
> >IOW:
> >The entry from MAINTAINER can be removed?
>
> This one for sure. The same is probably sensible for the
> drivers, too. It's just too confusing to not several
> versions of the driver floating around which need different
> tools. And since the manufacturer propagates their own
> version, the linux one should go...
>...


It's a question whether removing drivers from a stable kernel series is
a good idea, but the following is definitely correct:


--- linux-2.4.26-pre2-full/MAINTAINERS.old 2004-03-07 16:48:59.000000000 +0100
+++ linux-2.4.26-pre2-full/MAINTAINERS 2004-03-07 16:49:09.000000000 +0100
@@ -1077,12 +1077,6 @@
W: http://www.cse.unsw.edu.au/~neilb/oss/knfsd/
S: Maintained

-LANMEDIA WAN CARD DRIVER
-P: Andrew Stanley-Jones
-M: [email protected]
-W: http://www.lanmedia.com/
-S: Supported
-
LAPB module
P: Henner Eisen
M: [email protected]


> Servus,
> Daniel

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed


2004-03-08 05:37:48

by Marcelo Tosatti

[permalink] [raw]
Subject: Re: [2.4 patch] MAINTAINERS: remove LAN media entry



On Sun, 7 Mar 2004, Adrian Bunk wrote:

> On Sat, Feb 28, 2004 at 11:57:11AM +0100, Daniel Egger wrote:
> > On Feb 27, 2004, at 9:54 pm, Adrian Bunk wrote:
> >
> > >IOW:
> > >The entry from MAINTAINER can be removed?
> >
> > This one for sure. The same is probably sensible for the
> > drivers, too. It's just too confusing to not several
> > versions of the driver floating around which need different
> > tools. And since the manufacturer propagates their own
> > version, the linux one should go...
> >...
>
>
> It's a question whether removing drivers from a stable kernel series is
> a good idea, but the following is definitely correct:
>
>
> --- linux-2.4.26-pre2-full/MAINTAINERS.old 2004-03-07 16:48:59.000000000 +0100
> +++ linux-2.4.26-pre2-full/MAINTAINERS 2004-03-07 16:49:09.000000000 +0100
> @@ -1077,12 +1077,6 @@
> W: http://www.cse.unsw.edu.au/~neilb/oss/knfsd/
> S: Maintained
>
> -LANMEDIA WAN CARD DRIVER
> -P: Andrew Stanley-Jones
> -M: [email protected]
> -W: http://www.lanmedia.com/
> -S: Supported
> -
> LAPB module
> P: Henner Eisen
> M: [email protected]
>

I think it might be better to change to


LANMEDIA WAN CARD DRIVER
S: UNMAINTAINED

Thoughts?



2004-03-08 06:03:02

by YOSHIFUJI Hideaki

[permalink] [raw]
Subject: Re: [2.4 patch] MAINTAINERS: remove LAN media entry

In article <[email protected]> (at Mon, 8 Mar 2004 02:22:36 -0300 (BRT)), Marcelo Tosatti <[email protected]> says:

> > -LANMEDIA WAN CARD DRIVER
> > -P: Andrew Stanley-Jones
> > -M: [email protected]
> > -W: http://www.lanmedia.com/
> > -S: Supported
> > -
> > LAPB module
> > P: Henner Eisen
> > M: [email protected]
> >
>
> I think it might be better to change to
>
>
> LANMEDIA WAN CARD DRIVER
> S: UNMAINTAINED
>
> Thoughts?

"S" is one of the following (from MAINTAINERS):

Supported: Someone is actually paid to look after this.
Maintained: Someone actually looks after it.
Odd Fixes: It has a maintainer but they don't have time to do
much other than throw the odd patch in. See below..
Orphan: No current maintainer [but maybe you could take the
role as you write your new code].
Obsolete: Old code. Something tagged obsolete generally means
it has been replaced by a better system and you
should be using that.

--yoshfuji

2004-03-08 07:20:36

by Muli Ben-Yehuda

[permalink] [raw]
Subject: Re: [2.4 patch] MAINTAINERS: remove LAN media entry

On Mon, Mar 08, 2004 at 03:04:02PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
> In article <[email protected]> (at Mon, 8 Mar 2004 02:22:36 -0300 (BRT)), Marcelo Tosatti <[email protected]> says:

> > LANMEDIA WAN CARD DRIVER
> > S: UNMAINTAINED
> >
> > Thoughts?

Agreed. It's the easiest way to know that something is not
maintained.

> "S" is one of the following (from MAINTAINERS):
>
> Supported: Someone is actually paid to look after this.

Then we should add 'unmaintained'... something like this:

--- linux-2.4/MAINTAINERS.orig 2004-03-08 09:15:19.000000000 +0200
+++ linux-2.4/MAINTAINERS 2004-03-08 09:15:29.000000000 +0200
@@ -69,6 +69,7 @@
Obsolete: Old code. Something tagged obsolete generally means
it has been replaced by a better system and you
should be using that.
+ Unmaintained: Nobody is taking care of it. Maybe you want to?

3C359 NETWORK DRIVER
P: Mike Phillips
@@ -1078,10 +1079,7 @@
S: Maintained

LANMEDIA WAN CARD DRIVER
-P: Andrew Stanley-Jones
-M: [email protected]
-W: http://www.lanmedia.com/
-S: Supported
+S: Unmaintained

LAPB module
P: Henner Eisen

Cheers,
Muli
--
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/


Attachments:
(No filename) (1.27 kB)
signature.asc (189.00 B)
Digital signature
Download all attachments

2004-03-08 09:11:00

by YOSHIFUJI Hideaki

[permalink] [raw]
Subject: Re: [2.4 patch] MAINTAINERS: remove LAN media entry

In article <[email protected]> (at Mon, 8 Mar 2004 09:16:43 +0200), Muli Ben-Yehuda <[email protected]> says:

> > > LANMEDIA WAN CARD DRIVER
> > > S: UNMAINTAINED
:

> > "S" is one of the following (from MAINTAINERS):
> >
> > Supported: Someone is actually paid to look after this.
>
> Then we should add 'unmaintained'... something like this:
:
> should be using that.
> + Unmaintained: Nobody is taking care of it. Maybe you want to?
>
:

Well, I think "Orphan" is what this entry needs.

--yoshfuji

2004-03-08 12:55:07

by Horst H. von Brand

[permalink] [raw]
Subject: Re: [2.4 patch] MAINTAINERS: remove LAN media entry

Marcelo Tosatti <[email protected]> said:
> On Sun, 7 Mar 2004, Adrian Bunk wrote:
>
> > On Sat, Feb 28, 2004 at 11:57:11AM +0100, Daniel Egger wrote:
> > > On Feb 27, 2004, at 9:54 pm, Adrian Bunk wrote:
> > >
> > > >IOW:
> > > >The entry from MAINTAINER can be removed?
> > >
> > > This one for sure. The same is probably sensible for the
> > > drivers, too. It's just too confusing to not several
> > > versions of the driver floating around which need different
> > > tools. And since the manufacturer propagates their own
> > > version, the linux one should go...
> > >...
> >
> >
> > It's a question whether removing drivers from a stable kernel series is
> > a good idea, but the following is definitely correct:
> >
> >
> > --- linux-2.4.26-pre2-full/MAINTAINERS.old 2004-03-07 16:48:59.000000000 +0100
> > +++ linux-2.4.26-pre2-full/MAINTAINERS 2004-03-07 16:49:09.000000000 +0100
> > @@ -1077,12 +1077,6 @@
> > W: http://www.cse.unsw.edu.au/~neilb/oss/knfsd/
> > S: Maintained
> >
> > -LANMEDIA WAN CARD DRIVER
> > -P: Andrew Stanley-Jones
> > -M: [email protected]
> > -W: http://www.lanmedia.com/
> > -S: Supported
> > -
> > LAPB module
> > P: Henner Eisen
> > M: [email protected]
> >
>
> I think it might be better to change to
>
>
> LANMEDIA WAN CARD DRIVER
> S: UNMAINTAINED
>
> Thoughts?

Sounds right to me.
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513

2004-03-11 22:53:28

by Adrian Bunk

[permalink] [raw]
Subject: Re: [2.4 patch] MAINTAINERS: remove LAN media entry

On Mon, Mar 08, 2004 at 02:22:36AM -0300, Marcelo Tosatti wrote:
>
> > It's a question whether removing drivers from a stable kernel series is
> > a good idea, but the following is definitely correct:
> >
> >
> > --- linux-2.4.26-pre2-full/MAINTAINERS.old 2004-03-07 16:48:59.000000000 +0100
> > +++ linux-2.4.26-pre2-full/MAINTAINERS 2004-03-07 16:49:09.000000000 +0100
> > @@ -1077,12 +1077,6 @@
> > W: http://www.cse.unsw.edu.au/~neilb/oss/knfsd/
> > S: Maintained
> >
> > -LANMEDIA WAN CARD DRIVER
> > -P: Andrew Stanley-Jones
> > -M: [email protected]
> > -W: http://www.lanmedia.com/
> > -S: Supported
> > -
> > LAPB module
> > P: Henner Eisen
> > M: [email protected]
> >
>
> I think it might be better to change to
>
>
> LANMEDIA WAN CARD DRIVER
> S: UNMAINTAINED
>
> Thoughts?

I discussed this with Sam in the subthread regarding the 2.6 version of
this patch:
It seems to be the more common practice that non-maintained drivers
don't have an entry in MAINTAINERS.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed