2019-02-17 23:30:37

by Finn Thain

Subject: [PATCH] video/macfb: Call fb_invert_cmaps()

The 'inverse' parameter has no effect otherwise. Remove set-but-unused
variable.

Cc: [email protected]
Signed-off-by: Finn Thain <[email protected]>
---
drivers/video/fbdev/macfb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/macfb.c b/drivers/video/fbdev/macfb.c
index 00671055a611..37c56c45ee39 100644
--- a/drivers/video/fbdev/macfb.c
+++ b/drivers/video/fbdev/macfb.c
@@ -136,7 +136,6 @@ static struct fb_fix_screeninfo macfb_fix = {
static void *slot_addr;
static struct fb_info fb_info;
static u32 pseudo_palette[16];
-static int inverse;
static int vidtest;

/*
@@ -520,7 +519,7 @@ static void __init macfb_setup(char *options)
continue;

if (!strcmp(this_opt, "inverse"))
- inverse = 1;
+ fb_invert_cmaps();
else
if (!strcmp(this_opt, "vidtest"))
vidtest = 1; /* enable experimental CLUT code */
--
2.19.2

2019-04-01 12:05:18

by Bartlomiej Zolnierkiewicz

Subject: Re: [PATCH] video/macfb: Call fb_invert_cmaps()

On 02/18/2019 12:25 AM, Finn Thain wrote:
> The 'inverse' parameter has no effect otherwise. Remove set-but-unused
> variable.
>
> Cc: [email protected]
> Signed-off-by: Finn Thain <[email protected]>

Patch queued for v5.2, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics