2001-04-04 22:25:37

by Stuart McFadden

Subject: Underscore in rivafb

Hi,
The flashing block in rivafb was annoying me, so here is a diff (against
vanilla 2.4.3 ) of a quick hack in case anyone else was having the same problem.

Stuarty,

diff -urN linux.pure/drivers/video/riva/fbdev.c linux/drivers/video/riva/fbdev.c
--- linux.pure/drivers/video/riva/fbdev.c Wed Apr 4 22:34:19 2001
+++ linux/drivers/video/riva/fbdev.c Wed Apr 4 22:26:43 2001
@@ -534,7 +534,7 @@
struct riva_cursor *c = rinfo->cursor;
int i, j, idx;

- if (c) {
+ if (c) {
if (width <= 0 || height <= 0) {
width = 8;
height = 16;
@@ -547,13 +547,16 @@

idx = 0;

- for (i = 0; i < height; i++) {
- for (j = 0; j < width; j++,idx++)
- c->image[idx] = CURSOR_COLOR;
- for (j = width; j < MAX_CURS; j++,idx++)
+ for (i = MAX_CURS; i > height + 2; i--)
+ for (j = 0; j < MAX_CURS; j++,idx++)
c->image[idx] = TRANSPARENT_COLOR;
+ for (i = height + 2; i > height; i--) {
+ for (j = 0; j < width; j++,idx++)
+ c->image[idx] = CURSOR_COLOR;
+ for (j = width; j < MAX_CURS;j++,idx++)
+ c->image[idx] = TRANSPARENT_COLOR;
}
- for (i = height; i < MAX_CURS; i++)
+ for (i = height; i > 0; i--)
for (j = 0; j < MAX_CURS; j++,idx++)
c->image[idx] = TRANSPARENT_COLOR;
}



--
Start the day with a smile. After that you can be your nasty old self again.
- - - - - - - - - - - - - - - - - - - - -
Stuarty McFadden [email protected]

2001-04-04 23:17:39

by Petr Vandrovec

Subject: Re: Underscore in rivafb

Stuart McFadden wrote:
>
> Hi,
> The flashing block in rivafb was annoying me, so here is a diff (against
> vanilla 2.4.3 ) of a quick hack in case anyone else was having the same problem.

Get a look at
drivers/video/matrox/matroxfb_misc:matroxfb_createcursorshape, and
its callers, matroxfb_*_createcursor. If you'll use
conp->vc_cursor_type, standard
escape sequences for disabling cursor and for shape selection will work
on
riva then...
Petr Vandrovec
[email protected]

2001-04-05 04:12:35

by James Simmons

Subject: Re: Underscore in rivafb

linux/Documentation/VGA-softcursor.txt

MS: (n) 1. A debilitating and surprisingly widespread affliction that
renders the sufferer barely able to perform the simplest task. 2. A disease.

James Simmons [[email protected]] ____/|
fbdev/console/gfx developer \ o.O|
http://www.linux-fbdev.org =(_)=
http://linuxgfx.sourceforge.net U
http://linuxconsole.sourceforge.net

2001-04-05 10:08:16

by Stuart McFadden

Subject: Re: Underscore in rivafb

>linux/Documentation/VGA-softcursor.txt

Thanks, but I only seem to be able to change the colour of the cursor,
not the shape.

--
My polyvinyl cowboy wallet was made in Hong Kong by Montgomery Clift!
- - - - - - - - - - - - - - - - - - - - -
Stuarty McFadden [email protected]