2019-04-04 17:26:04

by Michal Suchánek

Subject: [PATCH] dmaengine: bcm2835: Drop duplicate capability setting.

Signed-off-by: Michal Suchanek <[email protected]>
---
drivers/dma/bcm2835-dma.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index ec8a291d62ba..e38b19dd2895 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -891,7 +891,6 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
dma_cap_set(DMA_SLAVE, od->ddev.cap_mask);
dma_cap_set(DMA_PRIVATE, od->ddev.cap_mask);
dma_cap_set(DMA_CYCLIC, od->ddev.cap_mask);
- dma_cap_set(DMA_SLAVE, od->ddev.cap_mask);
dma_cap_set(DMA_MEMCPY, od->ddev.cap_mask);
od->ddev.device_alloc_chan_resources = bcm2835_dma_alloc_chan_resources;
od->ddev.device_free_chan_resources = bcm2835_dma_free_chan_resources;
--
2.20.1

2019-04-05 07:11:22

by Stefan Wahren

Subject: Re: [PATCH] dmaengine: bcm2835: Drop duplicate capability setting.

Am 04.04.19 um 19:25 schrieb Michal Suchanek:
> Signed-off-by: Michal Suchanek <[email protected]>

Except of the point there is no commit log:

Acked-by: Stefan Wahren <[email protected]>

> ---
> drivers/dma/bcm2835-dma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index ec8a291d62ba..e38b19dd2895 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -891,7 +891,6 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
> dma_cap_set(DMA_SLAVE, od->ddev.cap_mask);
> dma_cap_set(DMA_PRIVATE, od->ddev.cap_mask);
> dma_cap_set(DMA_CYCLIC, od->ddev.cap_mask);
> - dma_cap_set(DMA_SLAVE, od->ddev.cap_mask);
> dma_cap_set(DMA_MEMCPY, od->ddev.cap_mask);
> od->ddev.device_alloc_chan_resources = bcm2835_dma_alloc_chan_resources;
> od->ddev.device_free_chan_resources = bcm2835_dma_free_chan_resources;

2019-04-26 11:25:00

by Vinod Koul

Subject: Re: [PATCH] dmaengine: bcm2835: Drop duplicate capability setting.

On 04-04-19, 19:25, Michal Suchanek wrote:
> Signed-off-by: Michal Suchanek <[email protected]>
> ---
> drivers/dma/bcm2835-dma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index ec8a291d62ba..e38b19dd2895 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -891,7 +891,6 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
> dma_cap_set(DMA_SLAVE, od->ddev.cap_mask);
> dma_cap_set(DMA_PRIVATE, od->ddev.cap_mask);
> dma_cap_set(DMA_CYCLIC, od->ddev.cap_mask);
> - dma_cap_set(DMA_SLAVE, od->ddev.cap_mask);
> dma_cap_set(DMA_MEMCPY, od->ddev.cap_mask);
> od->ddev.device_alloc_chan_resources = bcm2835_dma_alloc_chan_resources;
> od->ddev.device_free_chan_resources = bcm2835_dma_free_chan_resources;

Applied, thanks

--
~Vinod