2019-04-20 18:19:41

by Corentin LABBE

[permalink] [raw]
Subject: [PATCH] dt-bindings: add an explanation for internal phy-mode

When working on the Allwinner internal PHY, the first work was to use
the "internal" mode, but some answer was made my mail on what are really
internal mean for PHY.

This patch write that in the doc.

Signed-off-by: Corentin Labbe <[email protected]>
---
Documentation/devicetree/bindings/net/ethernet.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/ethernet.txt b/Documentation/devicetree/bindings/net/ethernet.txt
index cfc376bc977a..78b098d2d4e9 100644
--- a/Documentation/devicetree/bindings/net/ethernet.txt
+++ b/Documentation/devicetree/bindings/net/ethernet.txt
@@ -18,7 +18,8 @@ Documentation/devicetree/bindings/phy/phy-bindings.txt.
Specification).
- phy-mode: string, operation mode of the PHY interface. This is now a de-facto
standard property; supported values are:
- * "internal"
+ * "internal" (Internal means there is not a standard bus between the MAC and
+ the PHY, something proprietary is being used to embed the PHY in the MAC.)
* "mii"
* "gmii"
* "sgmii"
--
2.21.0


2019-04-21 17:52:27

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: add an explanation for internal phy-mode

On Sat, Apr 20, 2019 at 06:14:33PM +0000, Corentin Labbe wrote:
> When working on the Allwinner internal PHY, the first work was to use
> the "internal" mode, but some answer was made my mail on what are really
> internal mean for PHY.
>
> This patch write that in the doc.
>
> Signed-off-by: Corentin Labbe <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2019-04-21 18:28:06

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: add an explanation for internal phy-mode

From: Corentin Labbe <[email protected]>
Date: Sat, 20 Apr 2019 18:14:33 +0000

> When working on the Allwinner internal PHY, the first work was to use
> the "internal" mode, but some answer was made my mail on what are really
> internal mean for PHY.
>
> This patch write that in the doc.
>
> Signed-off-by: Corentin Labbe <[email protected]>

Applied, thank you.