> This patch cleans up needless includes of asm/pgalloc.h from the
> arch/s390/ subtree. This has not been compile tested, so
> needs the architecture maintainers (or willing volunteers) to
> test.
Doesn't compile. s390_ksyms needs pgalloc.h for the definition of diag10.
The other includes of pgalloc.h can be removed without a problem.
blue skies,
Martin
Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH
Sch?naicherstr. 220, D-71032 B?blingen, Telefon: 49 - (0)7031 - 16-2247
E-Mail: [email protected]
On Mon, Apr 19, 2004 at 05:56:19PM +0200, Martin Schwidefsky wrote:
> > This patch cleans up needless includes of asm/pgalloc.h from the
> > arch/s390/ subtree. This has not been compile tested, so
> > needs the architecture maintainers (or willing volunteers) to
> > test.
>
> Doesn't compile. s390_ksyms needs pgalloc.h for the definition of diag10.
> The other includes of pgalloc.h can be removed without a problem.
Alternatively, could the diag10() prototype be moved somewhere else
(tlbflush or cacheflush?) Is diag10 a tlb or cache function? It
isn't clear from the code what diag10() does.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
On Monday 19 April 2004 18:11, Russell King wrote:
> Alternatively, could the diag10() prototype be moved somewhere else
> (tlbflush or cacheflush?) ?Is diag10 a tlb or cache function? ?It
> isn't clear from the code what diag10() does.
Think of it as some sort of madvise(,,MADV_DONTNEED) or free() in
hardware. I guess the next best place to put it is <asm/system.h>.
Arnd <><