2004-04-23 14:02:56

by Felipe W Damasio

[permalink] [raw]

Subject: [PATCH] 32-bit process accounting

---

--- linux-2.6.6-rc2/include/linux/acct.h.orig Fri Apr 23 09:30:16 2004
+++ linux-2.6.6-rc2/include/linux/acct.h Fri Apr 23 09:31:16 2004
@@ -41,8 +41,8 @@
* No binary format break with 2.0 - but when we hit 32bit uid we'll
* have to bite one
*/
- __u16 ac_uid; /* Accounting Real User ID */
- __u16 ac_gid; /* Accounting Real Group ID */
+ uid_t ac_uid; /* Accounting Real User ID */
+ gid_t ac_gid; /* Accounting Real Group ID */
__u16 ac_tty; /* Accounting Control Terminal */
__u32 ac_btime; /* Accounting Process Creation Time */
comp_t ac_utime; /* Accounting User Time */

---

Attachments:

acct-32bit-config.patch (646.00 B)
acct-32bit.patch (609.00 B)
Download all attachments

2004-04-23 16:58:21

by Tim Schmielau

[permalink] [raw]

Subject: Re: [PATCH] 32-bit process accounting

---

On Fri, 23 Apr 2004, Felipe W Damasio wrote:

@@ -41,8 +41,8 @@
> * No binary format break with 2.0 - but when we hit 32bit uid we'll
> * have to bite one
> */
> - __u16 ac_uid; /* Accounting Real User ID
> */
> - __u16 ac_gid; /* Accounting Real Group ID */
> + uid_t ac_uid; /* Accounting Real User ID */
> + gid_t ac_gid; /* Accounting Real Group ID */
> __u16 ac_tty; /* Accounting Control Terminal */
> __u32 ac_btime; /* Accounting Process Creation Time */
> comp_t ac_utime; /* Accounting User Time */

This breaks binary compatibility, so you should change the comment as well.

Seriously, it's of course better not to break binary compatibility, as in
this patch
http://www.lib.uaa.alaska.edu/linux-kernel/archive/2004-Week-11/1337.html

I have to admit that things are moving a bit slow as I had no spare time
to push this patch. Will try to do that in the next week.

Tim