2004-04-28 07:29:31

by Meelis Roos

Subject: [2.6 PATCH] PPC32: compile error in signal.c

CC arch/ppc/kernel/signal.o
arch/ppc/kernel/signal.c: In function `handle_signal':
arch/ppc/kernel/signal.c:518: error: `newspp' undeclared (first use in this function)
arch/ppc/kernel/signal.c:518: error: (Each undeclared identifier is reported only once
arch/ppc/kernel/signal.c:518: error: for each function it appears in.)
arch/ppc/kernel/signal.c:518: warning: long unsigned int format, pointer arg (arg 3)

The following patch seems to fix it:

===== arch/ppc/kernel/signal.c 1.31 vs edited =====
--- 1.31/arch/ppc/kernel/signal.c Thu Apr 8 01:55:06 2004
+++ edited/arch/ppc/kernel/signal.c Wed Apr 28 10:27:20 2004
@@ -514,8 +514,8 @@

badframe:
#ifdef DEBUG_SIG
- printk("badframe in handle_signal, regs=%p frame=%lx newsp=%lx\n",
- regs, frame, *newspp);
+ printk("badframe in handle_signal, regs=%p frame=%p newsp=%lx\n",
+ regs, frame, newsp);
#endif
if (sig == SIGSEGV)
ka->sa.sa_handler = SIG_DFL;


--
Meelis Roos ([email protected])

2004-04-28 14:58:53

by Tom Rini

Subject: Re: [2.6 PATCH] PPC32: compile error in signal.c

On Wed, Apr 28, 2004 at 10:29:26AM +0300, Meelis Roos wrote:

> CC arch/ppc/kernel/signal.o
> arch/ppc/kernel/signal.c: In function `handle_signal':
> arch/ppc/kernel/signal.c:518: error: `newspp' undeclared (first use in this function)
> arch/ppc/kernel/signal.c:518: error: (Each undeclared identifier is reported only once
> arch/ppc/kernel/signal.c:518: error: for each function it appears in.)
> arch/ppc/kernel/signal.c:518: warning: long unsigned int format, pointer arg (arg 3)
>
> The following patch seems to fix it:

It's not quite complete, see http://lkml.org/lkml/2004/4/27/192 (and
akpm has sent this on to Linus already).

--
Tom Rini
http://gate.crashing.org/~trini/