2004-09-01 16:07:22

by Dave Jones

[permalink] [raw]
Subject: [PATCH] Remove redundant freeing code from aic7770

ahc_alloc already frees the 'name' if ahc=NULL

Spotted with the source checker from Coverity.com.

Signed-off-by: Dave Jones <[email protected]>


diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/scsi/aic7xxx/aic7770_osm.c linux-2.6/drivers/scsi/aic7xxx/aic7770_osm.c
--- bk-linus/drivers/scsi/aic7xxx/aic7770_osm.c 2004-06-03 13:40:05.000000000 +0100
+++ linux-2.6/drivers/scsi/aic7xxx/aic7770_osm.c 2004-06-03 13:42:30.000000000 +0100
@@ -185,10 +185,8 @@ aic7770_linux_config(struct aic7770_iden
return (ENOMEM);
strcpy(name, buf);
ahc = ahc_alloc(&aic7xxx_driver_template, name);
- if (ahc == NULL) {
- free(name, M_DEVBUF);
+ if (ahc == NULL)
return (ENOMEM);
- }
error = aic7770_config(ahc, entry, eisaBase);
if (error != 0) {
ahc->bsh.ioport = 0;