2004-09-05 02:55:20

by Adam J. Richter

Subject: linux-2.6.9-rc1-bk11/driver/char/drm/gamma_drm.c does not compile

drivers/char/drm/gramm_drm.c compiled under bk10, but fails
to compile under bk11. I think the bad patch was "DRM initial function
table support", at the URL
http://marc.theaimsgroup.com/?l=linux-kernel&m=109395880025924&w=2 .

It looks like gamma_driver_register_fns() tries to set some
nonexistant fields in dev->fn_tbl to point to some nonexistant
subroutines. I would guess that the lines from gamma_dma.c can just
be deleted, but perhaps this compile error indicates some more
substantial version skew.

drivers/char/drm/gamma_dma.c: In function `gamma_driver_register_fns':
drivers/char/drm/gamma_dma.c:943: error: structure has no member named `dma_flush_block_and_flush'
drivers/char/drm/gamma_dma.c:944: error: structure has no member named `dma_flush_unblock'

__ ______________
Adam J. Richter \ /
[email protected] | g g d r a s i l

2004-09-05 02:57:45

by Dave Airlie

Subject: Re: linux-2.6.9-rc1-bk11/driver/char/drm/gamma_drm.c does not compile

Gamma is marked as broken now it shouldn't even build anymore.. it is
broken, in more ways than makes it easy to fix, no DRI developer has any
major interest in it.. and we think we tracked down the 3 users ....

Dave.

On Sun, 5 Sep 2004, Adam J. Richter wrote:

> drivers/char/drm/gramm_drm.c compiled under bk10, but fails
> to compile under bk11. I think the bad patch was "DRM initial function
> table support", at the URL
> http://marc.theaimsgroup.com/?l=linux-kernel&m=109395880025924&w=2 .
>
> It looks like gamma_driver_register_fns() tries to set some
> nonexistant fields in dev->fn_tbl to point to some nonexistant
> subroutines. I would guess that the lines from gamma_dma.c can just
> be deleted, but perhaps this compile error indicates some more
> substantial version skew.
>
> drivers/char/drm/gamma_dma.c: In function `gamma_driver_register_fns':
> drivers/char/drm/gamma_dma.c:943: error: structure has no member named `dma_flush_block_and_flush'
> drivers/char/drm/gamma_dma.c:944: error: structure has no member named `dma_flush_unblock'
>
> __ ______________
> Adam J. Richter \ /
> [email protected] | g g d r a s i l
>

--
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
pam_smb / Linux DECstation / Linux VAX / ILUG person