2004-09-12 11:38:51

by Mikael Pettersson

Subject: [PATCH][2.4.28-pre3] Specialix RIO driver gcc-3.4 fixes

This patch fixes gcc-3.4 cast-as-lvalue warnings in the 2.4.28-pre3
kernel's Specialix RIO driver. The 2.6 version of the code has not
been fixed for gcc-3.4, so the changes are all new.

/Mikael

--- linux-2.4.28-pre3/drivers/char/rio/rio_linux.c.~1~ 2002-02-26 13:26:56.000000000 +0100
+++ linux-2.4.28-pre3/drivers/char/rio/rio_linux.c 2004-09-12 01:56:20.000000000 +0200
@@ -1206,7 +1206,7 @@
if (((1 << hp->Ivec) & rio_irqmask) == 0)
hp->Ivec = 0;
hp->CardP = (struct DpRam *)
- hp->Caddr = ioremap(p->RIOHosts[p->RIONumHosts].PaddrP, RIO_WINDOW_LEN);
+ (hp->Caddr = ioremap(p->RIOHosts[p->RIONumHosts].PaddrP, RIO_WINDOW_LEN));
hp->Type = RIO_PCI;
hp->Copy = rio_pcicopy;
hp->Mode = RIO_PCI_BOOT_FROM_RAM;
@@ -1278,7 +1278,7 @@
hp->Ivec = 0;
hp->Ivec |= 0x8000; /* Mark as non-sharable */
hp->CardP = (struct DpRam *)
- hp->Caddr = ioremap(p->RIOHosts[p->RIONumHosts].PaddrP, RIO_WINDOW_LEN);
+ (hp->Caddr = ioremap(p->RIOHosts[p->RIONumHosts].PaddrP, RIO_WINDOW_LEN));
hp->Type = RIO_PCI;
hp->Copy = rio_pcicopy;
hp->Mode = RIO_PCI_BOOT_FROM_RAM;
@@ -1330,7 +1330,7 @@
/* There was something about the IRQs of these cards. 'Forget what.--REW */
hp->Ivec = 0;
hp->CardP = (struct DpRam *)
- hp->Caddr = ioremap(p->RIOHosts[p->RIONumHosts].PaddrP, RIO_WINDOW_LEN);
+ (hp->Caddr = ioremap(p->RIOHosts[p->RIONumHosts].PaddrP, RIO_WINDOW_LEN));
hp->Type = RIO_AT;
hp->Copy = rio_pcicopy; /* AT card PCI???? - PVDL
* -- YES! this is now a normal copy. Only the

2004-09-14 20:18:03

by Marcelo Tosatti

Subject: Re: [PATCH][2.4.28-pre3] Specialix RIO driver gcc-3.4 fixes

On Sun, Sep 12, 2004 at 01:31:00PM +0200, Mikael Pettersson wrote:
> This patch fixes gcc-3.4 cast-as-lvalue warnings in the 2.4.28-pre3
> kernel's Specialix RIO driver. The 2.6 version of the code has not
> been fixed for gcc-3.4, so the changes are all new.
>

Hi Mikael

Get them in v2.6, too.

Trivial enough to be applied in v2.4.