2004-09-17 20:13:46

by Jesse Barnes

[permalink] [raw]
Subject: [PATCH] mmtimer cleanups

A few cleanups that probably should have been done a long time ago:

o remove test program from mmtimer.h
o move name, desc., etc. #defines from mmtimer.h to mmtimer.c
o document what mmtimer.c is a little better
o some whitespace cleanups for linewrapping and such

Signed-off-by: Jesse Barnes <[email protected]>

Thanks,
Jesse


Attachments:
(No filename) (336.00 B)
mmtimer-cleanups.patch (8.52 kB)
Download all attachments

2004-09-17 20:32:09

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH] mmtimer cleanups

On Fri, Sep 17, 2004 at 01:13:12PM -0700, Jesse Barnes wrote:
> A few cleanups that probably should have been done a long time ago:
>
> o remove test program from mmtimer.h
> o move name, desc., etc. #defines from mmtimer.h to mmtimer.c
> o document what mmtimer.c is a little better
> o some whitespace cleanups for linewrapping and such
>
> Signed-off-by: Jesse Barnes <[email protected]>
>
> Thanks,
> Jesse

> +#define MMTIMER_FULLNAME "/dev/mmtimer"

Shouldn't be needed ;-)

2004-09-21 15:27:40

by Jesse Barnes

[permalink] [raw]
Subject: Re: [PATCH] mmtimer cleanups

On Friday, September 17, 2004 4:28 pm, Christoph Hellwig wrote:
> On Fri, Sep 17, 2004 at 01:13:12PM -0700, Jesse Barnes wrote:
> > A few cleanups that probably should have been done a long time ago:
> >
> > o remove test program from mmtimer.h
> > o move name, desc., etc. #defines from mmtimer.h to mmtimer.c
> > o document what mmtimer.c is a little better
> > o some whitespace cleanups for linewrapping and such
> >
> > Signed-off-by: Jesse Barnes <[email protected]>
> >
> > Thanks,
> > Jesse
> >
> > +#define MMTIMER_FULLNAME "/dev/mmtimer"
>
> Shouldn't be needed ;-)

Updated patch that drops MMTIMER_FULLNAME.

Jesse

A few cleanups that probably should have been done a long time ago:

o remove test program from mmtimer.h
o move name, desc., etc. #defines from mmtimer.h to mmtimer.c
o document what mmtimer.c is a little better
o some whitespace cleanups for linewrapping and such

Signed-off-by: Jesse Barnes <[email protected]>


Attachments:
(No filename) (956.00 B)
mmtimer-cleanups-2.patch (8.48 kB)
Download all attachments