Hi Roman,
here is the updated patch for the driver model of the hp300 DIO bus.
Thanks for your comments!
Jochen
drivers/dio/Makefile | 2
drivers/dio/dio-driver.c | 163 +++++++++++++++++++++++++++
drivers/dio/dio-sysfs.c | 77 +++++++++++++
drivers/dio/dio.c | 209 +++++++++++------------------------
drivers/net/Space.c | 3
drivers/net/hplance.c | 126 +++++++++------------
drivers/serial/8250_hp300.c | 259 +++++++++++++++++++++-----------------------
drivers/video/hpfb.c | 122 +++++++++++---------
include/linux/dio.h | 155 +++++++++++++++++++++++---
9 files changed, 697 insertions(+), 419 deletions(-)
On Wed, 29 Sep 2004, Roman Zippel wrote:
> Hi,
>
> Jochen Friedrich wrote:
>
> >>There seem to be some whitespace problems. Also, please set your indent
> >>size to 8 (following the Linux kernel coding style described in
> >>Documentation/CodingStyle).
> >
> > OK, done. I have it attached this time. Hopefully the whitespace problems
> > are gone now.
>
> One more code style nitpick: Please change the if blocks to:
>
> if (...) {
> ...
> } else {
> ...
> }
>
> Otherwise it looks ok, although it might be better to post it once to
> the kernel mailing list, as there there are the people who know better
> the driver model.