Paul Mundt <[email protected]>, Nicolas Pitre <[email protected]>,
[email protected]
Subject: Re: [PATCH 2.6.9-rc4-mm1] [m32r] Fix smc91x driver for m32r
From: Hirokazu Takata <[email protected]>
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
X-Mailer: Mew version 3.3 on XEmacs 21.4.15 (Security Through Obscurity)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Hello,
Sorry, I've changed my mind, according to the thread of
"[PATCH] net: fix smc91x build for sh/ppc" (Oct 12, 2004).
I prefer that set_irq_type() is snipped by CONFIG_ARM, too.
Please throw away this patch and retrieve the previous
m32r-trivial-fix-of-smc91xh.patch again,
if the above patch "[PATCH] net: fix smc91x build for sh/ppc" is applied.
Thank you.
From: Jeff Garzik <[email protected]>
Subject: Re: [PATCH 2.6.9-rc4-mm1] [m32r] Fix smc91x driver for m32r
Date: Tue, 12 Oct 2004 11:51:21 -0400
> Hirokazu Takata wrote:
> > Just fix compile error of drivers/net/smc91x.c for m32r.
> >
> > It seems the previous patch (m32r-trivial-fix-of-smc91xh.patch) is too old.
> > So I will send a new patch.
> >
> > Please drop the previous patch
> > ( $ patch -R1 -p1 <m32r-trivial-fix-of-smc91xh.patch )
> > and apply the new one.
> >
> > * drivers/net/smc91x.h:
> > - Add set_irq_type() macro to ignore it for m32r.
> > - Fix RPC_LSA_DEFAULT and RPC_LSB_DEFAULT for an M3T-M32700UT board.
> >
> > Thanks.
> >
> > Signed-off-by: Hirokazu Takata <[email protected]>
>
> Seems OK to me, I'll put it into my netdev queue.
>
> For net driver patches, please always CC
> * [email protected], and
> * [email protected]
>
> Jeff
-- Takata