The patch below contains the following possible cleanups:
- journal.c: make cachefs_ondisc_ujnl_marks static
- misc.c: #if 0 the unused global function __cachefs_page_get_private
diffstat output:
fs/cachefs/journal.c | 2 +-
fs/cachefs/misc.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
Signed-off-by: Adrian Bunk <[email protected]>
--- linux-2.6.10-mm1-full/fs/cachefs/journal.c.old 2005-01-03 23:53:49.000000000 +0100
+++ linux-2.6.10-mm1-full/fs/cachefs/journal.c 2005-01-03 23:54:09.000000000 +0100
@@ -19,7 +19,7 @@
#define UJNL_WRAP(X) ((X) & (CACHEFS_ONDISC_UJNL_NUMENTS - 1))
-const char *cachefs_ondisc_ujnl_marks[] = {
+static const char *cachefs_ondisc_ujnl_marks[] = {
"Null ",
"Batch ",
"Ack ",
--- linux-2.6.10-mm1-full/fs/cachefs/misc.c.old 2005-01-03 23:54:20.000000000 +0100
+++ linux-2.6.10-mm1-full/fs/cachefs/misc.c 2005-01-03 23:54:37.000000000 +0100
@@ -30,6 +30,7 @@
* get a page caching token from for a page, allocating it and attaching it to
* the page's private pointer if it doesn't exist
*/
+#if 0
struct fscache_page * __cachefs_page_get_private(struct page *page,
unsigned gfp_flags)
{
@@ -51,6 +52,7 @@
} /* end __cachefs_page_get_private() */
EXPORT_SYMBOL(__cachefs_page_get_private);
+#endif /* 0 */
/*****************************************************************************/
/*
hoi :)
On Tue, Jan 04, 2005 at 12:53:40AM +0100, Adrian Bunk wrote:
> The patch below contains the following possible cleanups:
> - misc.c: #if 0 the unused global function __cachefs_page_get_private
it looks like this function should be removed, it is a duplicate of
__fscache_page_get_private in fs/fscache/page.c (from before the fscache split)
--
Martin Waitz