2005-01-08 16:06:32

by Magnus Damm

Subject: [PATCH] ide: possible typo in ide-disk.c

Hello,

A search for "task_no_data_intr" tells me that this is probably a typo.

/ magnus

Signed-off-by: Magnus Damm <[email protected]>

--- linux-2.6.10/drivers/ide/ide-disk.c 2004-12-24 22:34:32.000000000 +0100
+++ linux-2.6.10-ide_task_no_data_intr_20050108/drivers/ide/ide-disk.c 2005-01-08 16:24:26.000000000 +0100
@@ -1100,7 +1100,7 @@
case idedisk_pm_idle: /* Resume step 1 (idle) */
args->tfRegister[IDE_COMMAND_OFFSET] = WIN_IDLEIMMEDIATE;
args->command_type = IDE_DRIVE_TASK_NO_DATA;
- args->handler = task_no_data_intr;
+ args->handler = &task_no_data_intr;
return do_rw_taskfile(drive, args);

case idedisk_pm_restore_dma: /* Resume step 2 (restore DMA) */

2005-01-08 16:24:01

by Jeff Garzik

Subject: Re: [PATCH] ide: possible typo in ide-disk.c

Magnus Damm wrote:
> Hello,
>
> A search for "task_no_data_intr" tells me that this is probably a typo.
>
> / magnus
>
> Signed-off-by: Magnus Damm <[email protected]>
>
> --- linux-2.6.10/drivers/ide/ide-disk.c 2004-12-24 22:34:32.000000000 +0100
> +++ linux-2.6.10-ide_task_no_data_intr_20050108/drivers/ide/ide-disk.c 2005-01-08 16:24:26.000000000 +0100
> @@ -1100,7 +1100,7 @@
> case idedisk_pm_idle: /* Resume step 1 (idle) */
> args->tfRegister[IDE_COMMAND_OFFSET] = WIN_IDLEIMMEDIATE;
> args->command_type = IDE_DRIVE_TASK_NO_DATA;
> - args->handler = task_no_data_intr;
> + args->handler = &task_no_data_intr;

C101.

Jeff