2019-04-23 21:43:09

by Daniel G

Subject: [PATCH v2] iio: adxl372: declare missing of table

Add missing <of_device_id> table for SPI driver relying on SPI
device match since compatible is in a DT binding or in a DTS.

Before this patch:
modinfo drivers/iio/accel/adxl372_spi.ko | grep alias

After this patch:
modinfo drivers/iio/accel/adxl372_spi.ko | grep alias
alias: spi:adxl372
alias: of:N*T*Cadi,adxl372C*
alias: of:N*T*Cadi,adxl372

Reported-by: Javier Martinez Canillas <[email protected]>
Signed-off-by: Daniel Gomez <[email protected]>
---
drivers/iio/accel/adxl372_spi.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/drivers/iio/accel/adxl372_spi.c b/drivers/iio/accel/adxl372_spi.c
index e14e655..3ef7e3a 100644
--- a/drivers/iio/accel/adxl372_spi.c
+++ b/drivers/iio/accel/adxl372_spi.c
@@ -7,6 +7,8 @@

#include <linux/module.h>
#include <linux/regmap.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
#include <linux/spi/spi.h>

#include "adxl372.h"
@@ -37,9 +39,16 @@ static const struct spi_device_id adxl372_spi_id[] = {
};
MODULE_DEVICE_TABLE(spi, adxl372_spi_id);

+static const struct of_device_id adxl372_of_match[] = {
+ { .compatible = "adi,adxl372" },
+ { },
+};
+MODULE_DEVICE_TABLE(of, adxl372_of_match);
+
static struct spi_driver adxl372_spi_driver = {
.driver = {
.name = "adxl372_spi",
+ .of_match_table = adxl372_of_match,
},
.probe = adxl372_spi_probe,
.id_table = adxl372_spi_id,
--
2.7.4

2019-04-27 12:59:12

by Jonathan Cameron

Subject: Re: [PATCH v2] iio: adxl372: declare missing of table

On Tue, 23 Apr 2019 23:41:37 +0200
Daniel Gomez <[email protected]> wrote:

> Add missing <of_device_id> table for SPI driver relying on SPI
> device match since compatible is in a DT binding or in a DTS.
>
> Before this patch:
> modinfo drivers/iio/accel/adxl372_spi.ko | grep alias
>
> After this patch:
> modinfo drivers/iio/accel/adxl372_spi.ko | grep alias
> alias: spi:adxl372
> alias: of:N*T*Cadi,adxl372C*
> alias: of:N*T*Cadi,adxl372
>
> Reported-by: Javier Martinez Canillas <[email protected]>
> Signed-off-by: Daniel Gomez <[email protected]>
Applied.

Thanks,

Jonathan

> ---
> drivers/iio/accel/adxl372_spi.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/iio/accel/adxl372_spi.c b/drivers/iio/accel/adxl372_spi.c
> index e14e655..3ef7e3a 100644
> --- a/drivers/iio/accel/adxl372_spi.c
> +++ b/drivers/iio/accel/adxl372_spi.c
> @@ -7,6 +7,8 @@
>
> #include <linux/module.h>
> #include <linux/regmap.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> #include <linux/spi/spi.h>
>
> #include "adxl372.h"
> @@ -37,9 +39,16 @@ static const struct spi_device_id adxl372_spi_id[] = {
> };
> MODULE_DEVICE_TABLE(spi, adxl372_spi_id);
>
> +static const struct of_device_id adxl372_of_match[] = {
> + { .compatible = "adi,adxl372" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, adxl372_of_match);
> +
> static struct spi_driver adxl372_spi_driver = {
> .driver = {
> .name = "adxl372_spi",
> + .of_match_table = adxl372_of_match,
> },
> .probe = adxl372_spi_probe,
> .id_table = adxl372_spi_id,