2019-04-26 05:57:23

by Ran Wang

Subject: [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes

This patch adds USB dt nodes for LS1028A.

Signed-off-by: Ran Wang <[email protected]>
---
Changes in v2:
- Rename node from usb3@... to usb@... to meet DTSpec

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20 ++++++++++++++++++++
1 files changed, 20 insertions(+), 0 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 8dd3501..188cfb8 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -144,6 +144,26 @@
clocks = <&sysclk>;
};

+ usb0:usb@3100000 {
+ compatible= "snps,dwc3";
+ reg= <0x0 0x3100000 0x0 0x10000>;
+ interrupts= <0 80 0x4>;
+ dr_mode= "host";
+ snps,dis_rxdet_inp3_quirk;
+ snps,quirk-frame-length-adjustment = <0x20>;
+ snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+ };
+
+ usb1:usb@3110000 {
+ compatible= "snps,dwc3";
+ reg= <0x0 0x3110000 0x0 0x10000>;
+ interrupts= <0 81 0x4>;
+ dr_mode= "host";
+ snps,dis_rxdet_inp3_quirk;
+ snps,quirk-frame-length-adjustment = <0x20>;
+ snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+ };
+
i2c0: i2c@2000000 {
compatible = "fsl,vf610-i2c";
#address-cells = <1>;
--
1.7.1

2019-05-01 23:55:25

by Rob Herring (Arm)

Subject: Re: [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes

On Fri, Apr 26, 2019 at 05:54:26AM +0000, Ran Wang wrote:
> This patch adds USB dt nodes for LS1028A.
>
> Signed-off-by: Ran Wang <[email protected]>
> ---
> Changes in v2:
> - Rename node from usb3@... to usb@... to meet DTSpec
>
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20 ++++++++++++++++++++
> 1 files changed, 20 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 8dd3501..188cfb8 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -144,6 +144,26 @@
> clocks = <&sysclk>;
> };
>
> + usb0:usb@3100000 {
^ space needed

> + compatible= "snps,dwc3";

Needs an SoC specific compatible.

> + reg= <0x0 0x3100000 0x0 0x10000>;
> + interrupts= <0 80 0x4>;
> + dr_mode= "host";
> + snps,dis_rxdet_inp3_quirk;
> + snps,quirk-frame-length-adjustment = <0x20>;
> + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> + };
> +
> + usb1:usb@3110000 {
> + compatible= "snps,dwc3";
> + reg= <0x0 0x3110000 0x0 0x10000>;
> + interrupts= <0 81 0x4>;
> + dr_mode= "host";
> + snps,dis_rxdet_inp3_quirk;
> + snps,quirk-frame-length-adjustment = <0x20>;
> + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> + };
> +
> i2c0: i2c@2000000 {
> compatible = "fsl,vf610-i2c";
> #address-cells = <1>;
> --
> 1.7.1
>

2019-05-07 08:49:40

by Ran Wang

Subject: RE: [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes

Hi Rob,

On Thursday, May 02, 2019 07:54 Rob Herring wrote:
>
> On Fri, Apr 26, 2019 at 05:54:26AM +0000, Ran Wang wrote:
> > This patch adds USB dt nodes for LS1028A.
> >
> > Signed-off-by: Ran Wang <[email protected]>
> > ---
> > Changes in v2:
> > - Rename node from usb3@... to usb@... to meet DTSpec
> >
> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20
> ++++++++++++++++++++
> > 1 files changed, 20 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index 8dd3501..188cfb8 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -144,6 +144,26 @@
> > clocks = <&sysclk>;
> > };
> >
> > + usb0:usb@3100000 {
> ^ space needed

Yes, will update this in next version.

> > + compatible= "snps,dwc3";
>
> Needs an SoC specific compatible.

Do you mean change compatible to "snps,dwc3", "fsl,ls1028a-dwc3" ?

As I know, so far there is no SoC specific programming for this IP, so do
you think it's still necessary to add it?

Regards,
Ran

> > + reg= <0x0 0x3100000 0x0 0x10000>;
> > + interrupts= <0 80 0x4>;
> > + dr_mode= "host";
> > + snps,dis_rxdet_inp3_quirk;
> > + snps,quirk-frame-length-adjustment = <0x20>;
> > + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> > + };
> > +
> > + usb1:usb@3110000 {
> > + compatible= "snps,dwc3";
> > + reg= <0x0 0x3110000 0x0 0x10000>;
> > + interrupts= <0 81 0x4>;
> > + dr_mode= "host";
> > + snps,dis_rxdet_inp3_quirk;
> > + snps,quirk-frame-length-adjustment = <0x20>;
> > + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> > + };
> > +
> > i2c0: i2c@2000000 {
> > compatible = "fsl,vf610-i2c";
> > #address-cells = <1>;
> > --
> > 1.7.1
> >

2019-05-07 16:42:42

by Rob Herring (Arm)

Subject: Re: [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes

On Tue, May 7, 2019 at 3:48 AM Ran Wang <[email protected]> wrote:
>
> Hi Rob,
>
> On Thursday, May 02, 2019 07:54 Rob Herring wrote:
> >
> > On Fri, Apr 26, 2019 at 05:54:26AM +0000, Ran Wang wrote:
> > > This patch adds USB dt nodes for LS1028A.
> > >
> > > Signed-off-by: Ran Wang <[email protected]>
> > > ---
> > > Changes in v2:
> > > - Rename node from usb3@... to usb@... to meet DTSpec
> > >
> > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20
> > ++++++++++++++++++++
> > > 1 files changed, 20 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > index 8dd3501..188cfb8 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > @@ -144,6 +144,26 @@
> > > clocks = <&sysclk>;
> > > };
> > >
> > > + usb0:usb@3100000 {
> > ^ space needed
>
> Yes, will update this in next version.
>
> > > + compatible= "snps,dwc3";
> >
> > Needs an SoC specific compatible.
>
> Do you mean change compatible to "snps,dwc3", "fsl,ls1028a-dwc3" ?

Well, that's the wrong order, but yes.

> As I know, so far there is no SoC specific programming for this IP, so do
> you think it's still necessary to add it?

Yes. All the bugs and quirks are discovered already?

Rob

2019-05-08 02:22:04

by Ran Wang

Subject: RE: [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes

Hi Rob,

On Wednesday, May 08, 2019 00:40, Rob Herring wrote:
>
> On Tue, May 7, 2019 at 3:48 AM Ran Wang <[email protected]> wrote:
> >
> > Hi Rob,
> >
> > On Thursday, May 02, 2019 07:54 Rob Herring wrote:
> > >
> > > On Fri, Apr 26, 2019 at 05:54:26AM +0000, Ran Wang wrote:
> > > > This patch adds USB dt nodes for LS1028A.
> > > >
> > > > Signed-off-by: Ran Wang <[email protected]>
> > > > ---
> > > > Changes in v2:
> > > > - Rename node from usb3@... to usb@... to meet DTSpec
> > > >
> > > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20
> > > ++++++++++++++++++++
> > > > 1 files changed, 20 insertions(+), 0 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > index 8dd3501..188cfb8 100644
> > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > @@ -144,6 +144,26 @@
> > > > clocks = <&sysclk>;
> > > > };
> > > >
> > > > + usb0:usb@3100000 {
> > > ^ space needed
> >
> > Yes, will update this in next version.
> >
> > > > + compatible= "snps,dwc3";
> > >
> > > Needs an SoC specific compatible.
> >
> > Do you mean change compatible to "snps,dwc3", "fsl,ls1028a-dwc3" ?
>
> Well, that's the wrong order, but yes.

OK, will update this.

> > As I know, so far there is no SoC specific programming for this IP, so
> > do you think it's still necessary to add it?
>
> Yes. All the bugs and quirks are discovered already?

Yes, so far I don't receive any SoC specific defect report, I think it's fine.
Will work out next version patch, thanks for your time.

Regards,
Ran