2005-01-31 08:32:32

by Brown, Len

[permalink] [raw]
Subject: [BKPATCH] ACPI for 2.4

Hi Marcelo, please do a

bk pull bk://linux-acpi.bkbits.net/to-marcelo

thanks,
-Len

ps. a plain patch is also available here:
ftp://ftp.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/release/2.4.29/acpi-20040326-2.4.29.diff.gz

This will update the following files:

arch/i386/kernel/pci-irq.c | 4 ++--
arch/x86_64/kernel/pci-irq.c | 4 ++--
drivers/acpi/pci_irq.c | 4 ++++
drivers/pci/quirks.c | 30 +++++-------------------------
4 files changed, 13 insertions(+), 29 deletions(-)

through these ChangeSets:

<[email protected]> (05/01/26 1.1499.5.2)
[ACPI] via interrupt quirk fix from 2.6
http://bugzilla.kernel.org/show_bug.cgi?id=3319

Signed-off-by: David Shaohua Li <[email protected]>
Signed-off-by: Len Brown <[email protected].





2005-02-01 01:34:46

by Sergio Monteiro Basto

[permalink] [raw]
Subject: Re: [ACPI] [BKPATCH] ACPI for 2.4

Hi, cool

May I suggest a little more debug with this 2nd version of the patch in
attach ?.

I get dmesg | grep -i via
1. Disabling VIA memory write queue (PCI ID 0305, rev 80): [55] 3c & 1f -> 1c
2. PCI: Via IRQ fixup
3. Applying quirk_via_acpi.
4. Applying VIA southbridge workaround. (VIA Apollo KT133 needs PCI latency patch, applying quirk_vialatency).
5. PCI: Disabling Via external APIC routing

agpgart: Detected Via Apollo Pro KT133 chipset
VP_IDE: VIA vt82c686b (rev 42) IDE UDMA100 controller on pci00:07.1
parport_pc: Via 686A parallel port: io=0x378

1- the north bridge patch on arch/i386/kernel/pci-pc.c
2- the new patch
3- If ISA doesn't support PCI_INTERRUPT_LINE ?
* FIXME: it is questionable that quirk_via_acpi
* is needed. It shows up as an ISA bridge, and does not
* support the PCI_INTERRUPT_LINE register at all. Therefore
* it seems like setting the pci_dev's 'irq' to the
* value of the ACPI SCI interrupt is only done for convenience.
* -jgarzik

4- The general quirk, quirks all devices. Don't try to disable it, it
can damage the computer.
5- has a
/* TODO: When we have device-specific interrupt routers,
* this code will go away from quirks.
*/
but only with CONFIG_X86_IO_APIC, looks to me with no sense because, I
suppose I don't have any IO_APIC just one local apic.


thanks,


On Mon, 2005-01-31 at 03:32 -0500, Len Brown wrote:
> Hi Marcelo, please do a
>
> bk pull bk://linux-acpi.bkbits.net/to-marcelo
>
> thanks,
> -Len
>
> ps. a plain patch is also available here:
> ftp://ftp.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/release/2.4.29/acpi-20040326-2.4.29.diff.gz
>
> This will update the following files:
>
> arch/i386/kernel/pci-irq.c | 4 ++--
> arch/x86_64/kernel/pci-irq.c | 4 ++--
> drivers/acpi/pci_irq.c | 4 ++++
> drivers/pci/quirks.c | 30 +++++-------------------------
> 4 files changed, 13 insertions(+), 29 deletions(-)
>
> through these ChangeSets:
>
> <[email protected]> (05/01/26 1.1499.5.2)
> [ACPI] via interrupt quirk fix from 2.6
> http://bugzilla.kernel.org/show_bug.cgi?id=3319
>
> Signed-off-by: David Shaohua Li <[email protected]>
> Signed-off-by: Len Brown <[email protected].
>
>
>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
> Tool for open source databases. Create drag-&-drop reports. Save time
> by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
> Download a FREE copy at http://www.intelliview.com/go/osdn_nl
> _______________________________________________
> Acpi-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/acpi-devel
--
S?rgio M.B.


Attachments:
acpi-2.4.29v2.diff (4.66 kB)