Since it looks like ide is being worked on, can you convert ide to use
the PCI ROM access calls in drivers/pci/rom.c instead of directly
manipulating PCI config space? The new ROM calls work on all
architectures.
These are the places that need to be fix:
[jonsmirl@jonsmirl ide]$ grep -r PCI_ROM_ADDRESS_ENABLE *
pci/aec62xx.c: pci_write_config_dword(dev, PCI_ROM_ADDRESS,
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
pci/cmd64x.c: pci_write_config_byte(dev, PCI_ROM_ADDRESS,
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
pci/hpt34x.c:
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
pci/hpt366.c: dev->resource[PCI_ROM_RESOURCE].start
| PCI_ROM_ADDRESS_ENABLE);
pci/pdc202xx_new.c:
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
pci/pdc202xx_old.c:
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
[jonsmirl@jonsmirl ide]$
--
Jon Smirl
[email protected]
Jon Smirl wrote:
> Since it looks like ide is being worked on, can you convert ide to use
> the PCI ROM access calls in drivers/pci/rom.c instead of directly
> manipulating PCI config space? The new ROM calls work on all
> architectures.
>
> These are the places that need to be fix:
> [jonsmirl@jonsmirl ide]$ grep -r PCI_ROM_ADDRESS_ENABLE *
> pci/aec62xx.c: pci_write_config_dword(dev, PCI_ROM_ADDRESS,
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> pci/cmd64x.c: pci_write_config_byte(dev, PCI_ROM_ADDRESS,
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> pci/hpt34x.c:
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> pci/hpt366.c: dev->resource[PCI_ROM_RESOURCE].start
> | PCI_ROM_ADDRESS_ENABLE);
> pci/pdc202xx_new.c:
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> pci/pdc202xx_old.c:
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> [jonsmirl@jonsmirl ide]$
Sure, I'll look at it.
--
tejun