Hello, Bartlomiej.
These are reordered/modified/(hopefully)appliable nine patches from
the previous series of patches. #01 is the only new one. It kills
the unused pkt_task_t in ide.h. #02/#03 are moved upward and #04 is
modified as you've requested. #05/#08 now directly use taskfile
transport instead of calling ide_taskfile_ioctl(). #08 now also
properly handles WIN_SMART case.
If these patches go in, I have eight patches left. One of them is
ide_explicit_TASKFILE_NO_DATA. As we've discussed, I'm going to add
default initialization of task->[pre]handler. That patch wasn't
included in this series because I didn't know if do_rw_taskfile() and
flagged_taskfile() are going to be merged or not. So, please tell
me what you think. :-)
I'll talk about other patches in their reply threads.
[ Start of patch descriptions ]
01_ide_kill_pkt_task_t.patch
: kill unused pkt_task_t
Remove unused pkt_task_t definition from ide.h.
02_ide_taskfile_init_drive_cmd.patch
: ide_init_drive_cmd() now defaults to REQ_DRIVE_TASKFILE
ide_init_drive_cmd() now initializes rq->flags to
REQ_DRIVE_TASKFILE.
03_ide_diag_taskfile_use_init_drive_cmd.patch
: ide_diag_taskfile() rq initialization fix
In ide_diag_taskfile(), when initializing taskfile rq,
ref_count wasn't initialized properly. Modified to use
ide_init_drive_cmd(). This doesn't really change any behavior
as the request isn't managed via the block layer.
04_ide_taskfile_flush.patch
: convert REQ_DRIVE_TASK to REQ_DRIVE_TASKFILE
All REQ_DRIVE_TASK users except ide_task_ioctl() converted
to use REQ_DRIVE_TASKFILE.
1. idedisk_issue_flush() converted to use REQ_DRIVE_TASKFILE.
This and the changes in ide_get_error_location() remove a
possible race condition between ide_get_error_location()
and other requests.
2. ide_queue_flush_cmd() converted to use REQ_DRIVE_TASKFILE.
05_ide_taskfile_task_ioctl.patch
: map ide_task_ioctl() to ide_taskfile_ioctl()
ide_task_ioctl() modified to map to ide_taskfile_ioctl().
This is the last user of REQ_DRIVE_TASK.
06_ide_remove_task.patch
: remove REQ_DRIVE_TASK handling
Unused REQ_DRIVE_TASK handling removed.
07_ide_taskfile_cmd.patch
: convert REQ_DRIVE_CMD to REQ_DRIVE_TASKFILE
All in-kernel REQ_DRIVE_CMD users except for ide_cmd_ioctl()
converted to use REQ_DRIVE_TASKFILE.
08_ide_taskfile_cmd_ioctl.patch
: map ide_cmd_ioctl() to ide_taskfile_ioctl()
ide_cmd_ioctl() converted to use ide_taskfile_ioctl(). This
is the last user of REQ_DRIVE_CMD.
09_ide_remove_cmd.patch
: remove REQ_DRIVE_CMD handling
Removed unused REQ_DRIVE_CMD handling.
[ End of patch descriptions ]
Thanks.
--
tejun
Oops, I accidentally put ", ," in the To: line of all the mails which
contain patches, and they don't show up on the lkml. I'll post the
patches again.
Bartlomiej, if you got the first set of patches, please ignore them.
The contents are identical, so if you've already reviewed them, you
don't have to verify the new set. I'm really sorry. As I've been
making quite a few mistakes during mailing patches manually, I've
written a script to do it, but I still manage to make mistakes. :-(
--
tejun
Tejun Heo wrote:
>
> Oops, I accidentally put ", ," in the To: line of all the mails which
> contain patches, and they don't show up on the lkml. I'll post the
> patches again.
>
> Bartlomiej, if you got the first set of patches, please ignore them.
> The contents are identical, so if you've already reviewed them, you
> don't have to verify the new set. I'm really sorry. As I've been
> making quite a few mistakes during mailing patches manually, I've
> written a script to do it, but I still manage to make mistakes. :-(
>
I resent the patches and the same thing happened. I digged the
problem and found out that my script was faulty. The reason was that
the mail program didn't handle commas appropriately in to-addr list.
Bartlomiej, I sincerely apologize for polluting your mailbox yet again.
Please forgive me, it won't happen again (really!). :-)
I'll repost the patches in another thread. Sorry again about the mess.
--
tejun