2005-04-07 02:16:18

by Dave Airlie

[permalink] [raw]
Subject: [PATCH] r128_state.c: break missing in switch statement (fwd)


Hi Andrew/Linus,
Can you make sure this goes into 2.6.12? until you sort out the bk
thing I'll adopt this approach :-)

Dave.

drm: fix r128_state.c switch statements..
in drivers/char/drm/r128_state.c (linux-2.6.12-rc2), some breaks are
missing in the switch statement. See trivial fix below.

Signed-off-by: Hansjoerg Lipp <[email protected]>
Signed-off-by: Dave Airlie <[email protected]>

diff -urp linux-2.6.12-rc2/drivers/char/drm/r128_state.c linux-2.6.12-rc2-fix/drivers/char/drm/r128_state.c
--- linux-2.6.12-rc2/drivers/char/drm/r128_state.c 2005-04-06 13:18:05.000000000 +0200
+++ linux-2.6.12-rc2-fix/drivers/char/drm/r128_state.c 2005-04-06 13:23:50.000000000 +0200
@@ -1549,12 +1549,16 @@ static int r128_cce_depth( DRM_IOCTL_ARG
switch ( depth.func ) {
case R128_WRITE_SPAN:
ret = r128_cce_dispatch_write_span( dev, &depth );
+ break;
case R128_WRITE_PIXELS:
ret = r128_cce_dispatch_write_pixels( dev, &depth );
+ break;
case R128_READ_SPAN:
ret = r128_cce_dispatch_read_span( dev, &depth );
+ break;
case R128_READ_PIXELS:
ret = r128_cce_dispatch_read_pixels( dev, &depth );
+ break;
}

COMMIT_RING();