2005-04-27 10:47:43

by Jiri Benc

Subject: [PATCH] Typo in tulip driver

This patch fixes a typo in tulip driver in 2.6.12-rc3.


--- linux-2.6.12-rc3/drivers/net/tulip/tulip_core.c
+++ linux-2.6.12-rc3-patched/drivers/net/tulip/tulip_core.c
@@ -1104,7 +1109,7 @@ static void set_rx_mode(struct net_devic
if (entry != 0) {
/* Avoid a chip errata by prefixing a dummy entry. Don't do
this on the ULI526X as it triggers a different problem */
- if (!(tp->chip_id == ULI526X && (tp->revision = 0x40 || tp->revision == 0x50))) {
+ if (!(tp->chip_id == ULI526X && (tp->revision == 0x40 || tp->revision == 0x50))) {
tp->tx_buffers[entry].skb = NULL;
tp->tx_buffers[entry].mapping = 0;
tp->tx_ring[entry].length =


--
Jiri Benc
SUSE Labs

2005-05-16 03:19:11

by Jeff Garzik

Subject: Re: [PATCH] Typo in tulip driver

Jiri Benc wrote:
> This patch fixes a typo in tulip driver in 2.6.12-rc3.
>
>
> --- linux-2.6.12-rc3/drivers/net/tulip/tulip_core.c
> +++ linux-2.6.12-rc3-patched/drivers/net/tulip/tulip_core.c
> @@ -1104,7 +1109,7 @@ static void set_rx_mode(struct net_devic
> if (entry != 0) {
> /* Avoid a chip errata by prefixing a dummy entry. Don't do
> this on the ULI526X as it triggers a different problem */
> - if (!(tp->chip_id == ULI526X && (tp->revision = 0x40 || tp->revision == 0x50))) {
> + if (!(tp->chip_id == ULI526X && (tp->revision == 0x40 || tp->revision == 0x50))) {


applied