2001-07-20 14:00:41

by Nikita Danilov

Subject: patch to fs/proc/base.c

Hello,

following patch cures oopses in 2.4.7-pre9 when
proc_pid_make_inode() is called on task with task->mm == NULL.

Linus, please apply, if you haven't got a bunch of equivalent patches
already, which is doubtful.

Nikita.
------------------------------------------------------------
--- linux-2.4.7-pre9/fs/proc/base.c Fri Jul 20 14:57:55 2001
+++ linux-2.4.7-pre9.patched/fs/proc/base.c Fri Jul 20 17:03:23 2001
@@ -670,7 +670,7 @@ static struct inode *proc_pid_make_inode
inode->u.proc_i.task = task;
inode->i_uid = 0;
inode->i_gid = 0;
- if (ino == PROC_PID_INO || task->mm->dumpable) {
+ if (ino == PROC_PID_INO || (task->mm && task->mm->dumpable)) {
inode->i_uid = task->euid;
inode->i_gid = task->egid;
}
------------------------------------------------------------

2001-07-20 14:06:01

by Matti Aarnio

Subject: Re: patch to fs/proc/base.c

On Fri, Jul 20, 2001 at 05:59:51PM +0400, Nikita Danilov wrote:
> Date: Fri, 20 Jul 2001 17:59:51 +0400
> From: Nikita Danilov <[email protected]>
> To: [email protected]
> Subject: patch to fs/proc/base.c
>
> Hello,
>
> following patch cures oopses in 2.4.7-pre9 when
> proc_pid_make_inode() is called on task with task->mm == NULL.
>
> Linus, please apply, if you haven't got a bunch of equivalent patches
> already, which is doubtful.

He won't. For two reasons:
- There is better fix which Linus himself posted some hours ago
- Linus does not read (directly) linux-kernel list.

> Nikita.

/Matti Aarnio