2005-05-29 00:01:34

by Dave Jones

Subject: 2.6.12-rc5-git3 ia64 acpi build breakage.

This is puzzling.
In file included from drivers/firmware/pcdp.c:18:
drivers/firmware/pcdp.h:48: error: field 'addr' has incomplete type
drivers/firmware/pcdp.c: In function 'setup_serial_console':
drivers/firmware/pcdp.c:27: error: 'ACPI_ADR_SPACE_SYSTEM_MEMORY' undeclared (first use in this function)
drivers/firmware/pcdp.c:27: error: (Each undeclared identifier is reported only once
drivers/firmware/pcdp.c:27: error: for each function it appears in.)

First, I thought this was a simple missing
#include <acpi/actypes.h>

in drivers/firmware/pcdp.c

But it still spat out the same warning.

Dave

2005-05-29 08:14:25

by Alexey Dobriyan

Subject: Re: 2.6.12-rc5-git3 ia64 acpi build breakage.

On Sunday 29 May 2005 04:01, Dave Jones wrote:
> In file included from drivers/firmware/pcdp.c:18:
> drivers/firmware/pcdp.h:48: error: field 'addr' has incomplete type
> drivers/firmware/pcdp.c: In function 'setup_serial_console':
> drivers/firmware/pcdp.c:27: error: 'ACPI_ADR_SPACE_SYSTEM_MEMORY' undeclared (first use in this function)

This _should_ fix it.

--- linux-vanilla/include/linux/acpi.h 2005-05-28 02:59:59.000000000 +0400
+++ linux-8250/include/linux/acpi.h 2005-05-28 03:39:25.000000000 +0400
@@ -25,6 +25,8 @@
#ifndef _LINUX_ACPI_H
#define _LINUX_ACPI_H

+#include <linux/config.h>
+
#ifdef CONFIG_ACPI

#ifndef _LINUX