2019-04-29 15:17:15

by Geert Uytterhoeven

Subject: [PATCH] irqchip/renesas-intc-irqpin: Remove devm_kzalloc() error printing

There is no need to print a message if devm_kzalloc() fails, as the
memory allocation core already takes care of that.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/irqchip/irq-renesas-intc-irqpin.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-renesas-intc-irqpin.c b/drivers/irqchip/irq-renesas-intc-irqpin.c
index 8c039525703f7c9a..04c05a18600cf71f 100644
--- a/drivers/irqchip/irq-renesas-intc-irqpin.c
+++ b/drivers/irqchip/irq-renesas-intc-irqpin.c
@@ -389,10 +389,8 @@ static int intc_irqpin_probe(struct platform_device *pdev)
int k;

p = devm_kzalloc(dev, sizeof(*p), GFP_KERNEL);
- if (!p) {
- dev_err(dev, "failed to allocate driver data\n");
+ if (!p)
return -ENOMEM;
- }

/* deal with driver instance configuration */
of_property_read_u32(dev->of_node, "sense-bitfield-width",
--
2.17.1

2019-04-29 15:33:46

by Marc Zyngier

Subject: Re: [PATCH] irqchip/renesas-intc-irqpin: Remove devm_kzalloc() error printing

On 29/04/2019 16:15, Geert Uytterhoeven wrote:
> There is no need to print a message if devm_kzalloc() fails, as the
> memory allocation core already takes care of that.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Applied, thanks.

M.
--
Jazz is not dead. It just smells funny...