2019-05-10 19:58:05

by Bharath Vedartham

Subject: [PATCH] mm/gup.c: Make follow_page_mask static

follow_page_mask is only used in gup.c, make it static.

Tested by compiling and booting. Grepped the source for
"follow_page_mask" to be sure it is not used else where.

Signed-off-by: Bharath Vedartham <[email protected]>
---
mm/gup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/gup.c b/mm/gup.c
index 91819b8..e6f3b7f 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -409,7 +409,7 @@ static struct page *follow_p4d_mask(struct vm_area_struct *vma,
* an error pointer if there is a mapping to something not represented
* by a page descriptor (see also vm_normal_page()).
*/
-struct page *follow_page_mask(struct vm_area_struct *vma,
+static struct page *follow_page_mask(struct vm_area_struct *vma,
unsigned long address, unsigned int flags,
struct follow_page_context *ctx)
{
--
2.7.4

2019-05-11 00:07:07

by Ira Weiny

Subject: Re: [PATCH] mm/gup.c: Make follow_page_mask static

On Sat, May 11, 2019 at 12:38:32AM +0530, Bharath Vedartham wrote:
> follow_page_mask is only used in gup.c, make it static.
>
> Tested by compiling and booting. Grepped the source for
> "follow_page_mask" to be sure it is not used else where.
>
> Signed-off-by: Bharath Vedartham <[email protected]>

Reviewed-by: Ira Weiny <[email protected]>

> ---
> mm/gup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index 91819b8..e6f3b7f 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -409,7 +409,7 @@ static struct page *follow_p4d_mask(struct vm_area_struct *vma,
> * an error pointer if there is a mapping to something not represented
> * by a page descriptor (see also vm_normal_page()).
> */
> -struct page *follow_page_mask(struct vm_area_struct *vma,
> +static struct page *follow_page_mask(struct vm_area_struct *vma,
> unsigned long address, unsigned int flags,
> struct follow_page_context *ctx)
> {
> --
> 2.7.4
>