2019-05-11 10:06:43

by Daniel G

Subject: [PATCH v2] mfd: madera: Add missing of table registration

MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
OF mathing mechanism and register it.

Before this patch:
modinfo ./drivers/mfd/madera.ko | grep alias

After this patch:
modinfo ./drivers/mfd/madera.ko | grep alias
alias: of:N*T*Ccirrus,wm1840C*
alias: of:N*T*Ccirrus,wm1840
alias: of:N*T*Ccirrus,cs47l91C*
alias: of:N*T*Ccirrus,cs47l91
alias: of:N*T*Ccirrus,cs47l90C*
alias: of:N*T*Ccirrus,cs47l90
alias: of:N*T*Ccirrus,cs47l85C*
alias: of:N*T*Ccirrus,cs47l85
alias: of:N*T*Ccirrus,cs47l35C*
alias: of:N*T*Ccirrus,cs47l35

Reported-by: Javier Martinez Canillas <[email protected]>
Signed-off-by: Daniel Gomez <[email protected]>
---
drivers/mfd/madera-core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index 2a77988..826b971 100644
--- a/drivers/mfd/madera-core.c
+++ b/drivers/mfd/madera-core.c
@@ -286,6 +286,7 @@ const struct of_device_id madera_of_match[] = {
{ .compatible = "cirrus,wm1840", .data = (void *)WM1840 },
{}
};
+MODULE_DEVICE_TABLE(of, madera_of_match);
EXPORT_SYMBOL_GPL(madera_of_match);

static int madera_get_reset_gpio(struct madera *madera)
--
2.7.4

2019-05-13 09:10:26

by Charles Keepax

Subject: Re: [PATCH v2] mfd: madera: Add missing of table registration

On Sat, May 11, 2019 at 12:03:58PM +0200, Daniel Gomez wrote:
> MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
> OF mathing mechanism and register it.
>
> Before this patch:
> modinfo ./drivers/mfd/madera.ko | grep alias
>
> After this patch:
> modinfo ./drivers/mfd/madera.ko | grep alias
> alias: of:N*T*Ccirrus,wm1840C*
> alias: of:N*T*Ccirrus,wm1840
> alias: of:N*T*Ccirrus,cs47l91C*
> alias: of:N*T*Ccirrus,cs47l91
> alias: of:N*T*Ccirrus,cs47l90C*
> alias: of:N*T*Ccirrus,cs47l90
> alias: of:N*T*Ccirrus,cs47l85C*
> alias: of:N*T*Ccirrus,cs47l85
> alias: of:N*T*Ccirrus,cs47l35C*
> alias: of:N*T*Ccirrus,cs47l35
>
> Reported-by: Javier Martinez Canillas <[email protected]>
> Signed-off-by: Daniel Gomez <[email protected]>
> ---

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles

2019-06-03 07:32:17

by Lee Jones

Subject: Re: [PATCH v2] mfd: madera: Add missing of table registration

On Sat, 11 May 2019, Daniel Gomez wrote:

> MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
> OF mathing mechanism and register it.
>
> Before this patch:
> modinfo ./drivers/mfd/madera.ko | grep alias
>
> After this patch:
> modinfo ./drivers/mfd/madera.ko | grep alias
> alias: of:N*T*Ccirrus,wm1840C*
> alias: of:N*T*Ccirrus,wm1840
> alias: of:N*T*Ccirrus,cs47l91C*
> alias: of:N*T*Ccirrus,cs47l91
> alias: of:N*T*Ccirrus,cs47l90C*
> alias: of:N*T*Ccirrus,cs47l90
> alias: of:N*T*Ccirrus,cs47l85C*
> alias: of:N*T*Ccirrus,cs47l85
> alias: of:N*T*Ccirrus,cs47l35C*
> alias: of:N*T*Ccirrus,cs47l35
>
> Reported-by: Javier Martinez Canillas <[email protected]>
> Signed-off-by: Daniel Gomez <[email protected]>
> ---
> drivers/mfd/madera-core.c | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog