2005-11-10 22:14:15

by Dave Jones

Subject: saa711x driver doesn't need segment.h

This breaks compilation on non-x86 architectures,
and isn't even used.

Signed-off-by: Dave Jones <[email protected]>

--- linux-2.6.14/drivers/media/video/saa711x.c~ 2005-11-10 15:27:05.000000000 -0500
+++ linux-2.6.14/drivers/media/video/saa711x.c 2005-11-10 15:27:33.000000000 -0500
@@ -36,7 +36,6 @@
#include <asm/pgtable.h>
#include <asm/page.h>
#include <linux/sched.h>
-#include <asm/segment.h>
#include <linux/types.h>
#include <asm/uaccess.h>
#include <linux/videodev.h>

2005-11-10 22:21:05

by Michael Ira Krufky

Subject: Re: saa711x driver doesn't need segment.h

Dave Jones wrote:

>This breaks compilation on non-x86 architectures,
>and isn't even used.
>
>Signed-off-by: Dave Jones <[email protected]>
>
>--- linux-2.6.14/drivers/media/video/saa711x.c~ 2005-11-10 15:27:05.000000000 -0500
>+++ linux-2.6.14/drivers/media/video/saa711x.c 2005-11-10 15:27:33.000000000 -0500
>@@ -36,7 +36,6 @@
> #include <asm/pgtable.h>
> #include <asm/page.h>
> #include <linux/sched.h>
>-#include <asm/segment.h>
> #include <linux/types.h>
> #include <asm/uaccess.h>
> #include <linux/videodev.h>
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to [email protected]
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
Acked-by: Michael Krufky <[email protected]>

Andrew-

Due to the above fix, please revert:

saa711x-is-busted-on-ppc64.patch

Thank you.

--
Michael Krufky

2005-11-16 06:39:20

by Dwaine Garden VE3GIF

Subject: Re: saa711x driver doesn't need segment.h

Mike Krufky wrote:
> Dave Jones wrote:
>
>> This breaks compilation on non-x86 architectures,
>> and isn't even used.
>>
>> Signed-off-by: Dave Jones <[email protected]>
>>
>> --- linux-2.6.14/drivers/media/video/saa711x.c~ 2005-11-10
>> 15:27:05.000000000 -0500
>> +++ linux-2.6.14/drivers/media/video/saa711x.c 2005-11-10
>> 15:27:33.000000000 -0500
>> @@ -36,7 +36,6 @@
>> #include <asm/pgtable.h>
>> #include <asm/page.h>
>> #include <linux/sched.h>
>> -#include <asm/segment.h>
>> #include <linux/types.h>
>> #include <asm/uaccess.h>
>> #include <linux/videodev.h>
>> -
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-kernel" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>>
> Acked-by: Michael Krufky <[email protected]>
>
> Andrew-
>
> Due to the above fix, please revert:
>
> saa711x-is-busted-on-ppc64.patch
>
> Thank you.
>
Just tested out saa711x module with the USBVision driver and it works
perfectly. It's nice to have this module included with the v4l.